At Mark's request I have implemented a change to the command prompt after switching to secure mode: OVMS > ena Password: Secure mode OVMS # As implemented in this commit, the color also changes from green to red, but that is only a proposal. I also looked at blue, but on my terminal it's not so distinct from black. If preferred, we can have both modes be green. Actually, as I thought about this, I wondered whether our console welcome banner and prompt should be different from green since all the info-level log messages are green. But there are not many ANSI color choices and they don't look the same on all terminals, so we can't get carried away with this. -- Steve
Hi Steve, Like the new prompt, not so convinced about the color. Being color blind, it's a lot more of a nuisance than it's worth, especially when there is such a variability in displays. And, it's not like we're accessing something so highly sensitive that we need blinking fonts, warning claxons, and colored text. My $.02, keep the pound sign, leave the color the same. Greg Stephen Casner wrote:
At Mark's request I have implemented a change to the command prompt after switching to secure mode:
OVMS > ena Password: Secure mode OVMS #
As implemented in this commit, the color also changes from green to red, but that is only a proposal. I also looked at blue, but on my terminal it's not so distinct from black. If preferred, we can have both modes be green.
Actually, as I thought about this, I wondered whether our console welcome banner and prompt should be different from green since all the info-level log messages are green. But there are not many ANSI color choices and they don't look the same on all terminals, so we can't get carried away with this.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
My $0.02 is I like the “OVMS >” vs “OVMS #” (very clear), but the red colour doesn’t do it for me. In fact, in general we have green for OK and red for ERROR, which is the same for the ESP_LOG messages. So, how about leave both consoles green colour, or just plain white? Regards, Mark.
On 18 Mar 2018, at 2:51 PM, Greg D. <gregd2350@gmail.com> wrote:
Hi Steve,
Like the new prompt, not so convinced about the color. Being color blind, it's a lot more of a nuisance than it's worth, especially when there is such a variability in displays. And, it's not like we're accessing something so highly sensitive that we need blinking fonts, warning claxons, and colored text. My $.02, keep the pound sign, leave the color the same.
Greg
Stephen Casner wrote:
At Mark's request I have implemented a change to the command prompt after switching to secure mode:
OVMS > ena Password: Secure mode OVMS #
As implemented in this commit, the color also changes from green to red, but that is only a proposal. I also looked at blue, but on my terminal it's not so distinct from black. If preferred, we can have both modes be green.
Actually, as I thought about this, I wondered whether our console welcome banner and prompt should be different from green since all the info-level log messages are green. But there are not many ANSI color choices and they don't look the same on all terminals, so we can't get carried away with this.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
I tried not changing colours at all. Just leave that at whatever the terminal program has chosen. Committed for people to look at. Again, just a proposal - feel free to play. Regards, Mark
On 18 Mar 2018, at 4:35 PM, Mark Webb-Johnson <mark@webb-johnson.net> wrote:
My $0.02 is I like the “OVMS >” vs “OVMS #” (very clear), but the red colour doesn’t do it for me.
In fact, in general we have green for OK and red for ERROR, which is the same for the ESP_LOG messages.
So, how about leave both consoles green colour, or just plain white?
Regards, Mark.
On 18 Mar 2018, at 2:51 PM, Greg D. <gregd2350@gmail.com> wrote:
Hi Steve,
Like the new prompt, not so convinced about the color. Being color blind, it's a lot more of a nuisance than it's worth, especially when there is such a variability in displays. And, it's not like we're accessing something so highly sensitive that we need blinking fonts, warning claxons, and colored text. My $.02, keep the pound sign, leave the color the same.
Greg
Stephen Casner wrote:
At Mark's request I have implemented a change to the command prompt after switching to secure mode:
OVMS > ena Password: Secure mode OVMS #
As implemented in this commit, the color also changes from green to red, but that is only a proposal. I also looked at blue, but on my terminal it's not so distinct from black. If preferred, we can have both modes be green.
Actually, as I thought about this, I wondered whether our console welcome banner and prompt should be different from green since all the info-level log messages are green. But there are not many ANSI color choices and they don't look the same on all terminals, so we can't get carried away with this.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
I'm fine with not setting a color on the prompts. Perhaps the color should also be removed from the welcome banner? -- Steve On Sun, 18 Mar 2018, Mark Webb-Johnson wrote:
I tried not changing colours at all. Just leave that at whatever the terminal program has chosen.
Committed for people to look at. Again, just a proposal - feel free to play.
Regards, Mark
On 18 Mar 2018, at 4:35 PM, Mark Webb-Johnson <mark@webb-johnson.net> wrote:
My $0.02 is I like the "OVMS >" vs "OVMS #" (very clear), but the red colour doesn't do it for me.
In fact, in general we have green for OK and red for ERROR, which is the same for the ESP_LOG messages.
So, how about leave both consoles green colour, or just plain white?
Regards, Mark.
On 18 Mar 2018, at 2:51 PM, Greg D. <gregd2350@gmail.com> wrote:
Hi Steve,
Like the new prompt, not so convinced about the color. Being color blind, it's a lot more of a nuisance than it's worth, especially when there is such a variability in displays. And, it's not like we're accessing something so highly sensitive that we need blinking fonts, warning claxons, and colored text. My $.02, keep the pound sign, leave the color the same.
Greg
Stephen Casner wrote:
At Mark's request I have implemented a change to the command prompt after switching to secure mode:
OVMS > ena Password: Secure mode OVMS #
As implemented in this commit, the color also changes from green to red, but that is only a proposal. I also looked at blue, but on my terminal it's not so distinct from black. If preferred, we can have both modes be green.
Actually, as I thought about this, I wondered whether our console welcome banner and prompt should be different from green since all the info-level log messages are green. But there are not many ANSI color choices and they don't look the same on all terminals, so we can't get carried away with this.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
Colored banner is fine. Nice touch. Do I need to do anything in the obdii code to fix the security issues, or is that taken care of in the command parser? Greg Stephen Casner wrote:
I'm fine with not setting a color on the prompts. Perhaps the color should also be removed from the welcome banner?
-- Steve
Greg, you need to set the secure flag as required on your command registration: OvmsCommand* OvmsCommand::RegisterCommand(const char* name, const char* title, void (*execute)(int, OvmsWriter*, OvmsCommand*, int, const char* const*), const char *usage, int min, int max, *bool secure*) Everything else is handled by the system. Regards, Michael Am 18.03.2018 um 17:47 schrieb Greg D.:
Colored banner is fine. Nice touch.
Do I need to do anything in the obdii code to fix the security issues, or is that taken care of in the command parser?
Greg
Stephen Casner wrote:
I'm fine with not setting a color on the prompts. Perhaps the color should also be removed from the welcome banner?
-- Steve
OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
participants (4)
-
Greg D. -
Mark Webb-Johnson -
Michael Balzer -
Stephen Casner