Perfect.  Done; pull request created.

I considered leaving the 'obdii ecu list' command as not secure, as normally it's just mph and such, but someone could mess with the PID mapping and create an issue there.  Also, the list can report what PIDs are being requested by the OBDII device, which could be an information leak.

Greg


Michael Balzer wrote:
Greg,

you need to set the secure flag as required on your command registration:

OvmsCommand* OvmsCommand::RegisterCommand(const char* name, const char* title, void (*execute)(int, OvmsWriter*, OvmsCommand*, int, const char* const*),
                                          const char *usage, int min, int max, bool secure)

Everything else is handled by the system.

Regards,
Michael


Am 18.03.2018 um 17:47 schrieb Greg D.:
Colored banner is fine.  Nice touch.

Do I need to do anything in the obdii code to fix the security issues,
or is that taken care of in the command parser?

Greg


Stephen Casner wrote:

I'm fine with not setting a color on the prompts.  Perhaps the color
should also be removed from the welcome banner?

                                                        -- Steve

_______________________________________________
OvmsDev mailing list
OvmsDev@lists.teslaclub.hk
http://lists.teslaclub.hk/mailman/listinfo/ovmsdev


-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26



_______________________________________________
OvmsDev mailing list
OvmsDev@lists.teslaclub.hk
http://lists.teslaclub.hk/mailman/listinfo/ovmsdev