Hi list,
I started to split my big list of patches into smaller, more manageable, easier to review PRs:
- missing headers <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/825> #825
- ESP-IDF v5+: dependency on ovms_webserver.h <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/824> #824
- ESP-IDF v5+: change type of TaskHandle_t <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/823>#823
- changes to (long deprecated) ADC constants <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/822> #822
- ESP-IDF v5+: static assertion failed: std::vector must have the same value_type as its allocator <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/821> #821
- ESP-IDF v5+: static assertion failed: comparison object must be invocable as const <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/820> #820
- ESP-IDF v4+ : remove deprecated and unused esp_event_loop.h <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/819> #819
- remove warning by replacing rom/queue.h with sys/queue.h <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/818> #818
- remove warning : '_GNU_SOURCE' redefined <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/817> #817
- ESP-IDF v4+ : esp_intr.h is deprecated, replaced by esp_intr_alloc.h <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/816> #816
- Add header and fix function signature <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/815> #815
- replace some constants with their more adapted counterpart <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/813> #813
Let me know if it's the proper approach ; and if some of you can review those changes and comment on them, it'll help merging those - and progress in reaching ESP-IDFv5 compatibility.
Best regards,
Le 31/01/2023 à 01:49, Ludovic LANGE a écrit :
Hi list,
Another quick post to share with you the progress on the ESP-IDFv5 + cmake endeavour:
ESP-IDF v5 version of OVMSv3 is now officially booting and seems to work fine (then again, I'm not doing any real-world testing for lack of time / car at the moment - it's here that you can help me) with a few caveats detailed in the PR or the README.md <https://github.com/llange/Open-Vehicle-Monitoring-System-3/blob/experimental-esp-idf-v5/README.md>.
The branch https://github.com/llange/Open-Vehicle-Monitoring-System-3/tree/experimental... is now ready for testing, sharing, studying, ...
I created a draft PR https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/810 (just like for ESP-IDFv4), in order to show the diff and gather feedback. Not to be merged as-is.
I'll try to break it into smaller low-impact / easy-to-review PR's that could be merged as-is in current master (warning corrections, header definitions, xxprintf type impact, etc...), so that the big pieces could be more easily reviewed.
Please note that those branches / PRs are still Work-In-Progress, and that I may certainly (and wrongly)
push --forcesome changes as I rebase, update or split the big PR into smaller, easy to study PRs. I'll try not to but can't promise :-) So if you checkout the branch, please be warned and know your git commands to either reset or rebase your working copy...Next on my list are, in no particular order:
- Have a few patches/bugs fixed in upstream wolfSSL (in progress) in order to enable
- Check to see if we could upgrade mongoose (not absolutely necessary because it works / compile OK with a small patch)
- Fix the remaining warnings o And change the ADC implementation that is deprecated now o deprecation of esp_vfs_fat_spiflash_mount / esp_vfs_fat_spiflash_unmount
- Fix the WIP WIP WIP commits
- Resume work on https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/issues/752
Boot time warnings to study and check if OK:
- W (1091) esp_psram: Virtual address not enough for PSRAM, map as much as we can. 4MB is mapped
- W (2132) ADC: legacy driver is deprecated, please migrate to
esp_adc/adc_oneshot.h(<- this one is easy to understand...)Additional instructions:
When first building, your sdkconfig will be converted as some config options did change betwen ESP-IDF v3.x and v5.x.
Run
menuconfigand :
- *Select FREERTOS_ENABLE_BACKWARD_COMPATIBILITY*(=y) "configENABLE_BACKWARD_COMPATIBILITY"
- *Unselect MG_ENABLE_SSL*(=n) "Enable MONGOOSE SSL/TLS support"
If any of you with some free time could be nice enough to try to reproduce such a build and share the experience here. Let me know how the instructions could be updated and what issues you are facing.
Best regards,