[Ovmsdev] OVMS Poller module/singleton

[Chris Box]

> Am 15.01.25 um 11:11 schrieb Michael Balzer via OvmsDev:
> 
>> Speaking of the Leaf, the code there actually does something fishy in 
>> `CommandWakeup()`:
>> 
>> unsigned char data = 0;
>> ...
>> m_can1->WriteStandard(0x5C0, 8, &data); //Wakes up the VCM (by 
>> spoofing empty battery request heating)

I agree that is dodgy. It's going to write 8 bytes of data onto the bus, 
but only the first byte's contents are known. The other 7 are 
nondeterministic - just whatever happened to be on the stack at that 
time. This doesn't seem like a recipe for predictable operation.

The commit was 
https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commit/09c58a2feda13c32f79c6599fdcb6a7512cf1a48 
by dalathegreat.

Unfortunately my CAN knowledge is close to zero so I can't comment on 
the messages themselves.

Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20250204/8997cf98/attachment.htm>