[Ovmsdev] Can't compile due to wolfssh

[Ludovic LANGE]

Indeed I was going to suggest that you pull fresh from master in another 
new dir in fact.

When doing so, you should have:

  * "vehicle/OVMS.V3/components/wolfssh/wolfssh" as a submodule
  * "vehicle/OVMS.V3/components/wolfssl/wolfssl" as a normal dir (for
    now. Will change in a few PR's)

You can check that with :

$ git submodule status
  7b953e7ebb440ce9461ee469159c3759450e7c98 vehicle/OVMS.V3/components/mongoose/mongoose (6.2-882-g7b953e7)
  c05f6c7530a8670e3d0ffdf04ee4cecb2d3b0496 vehicle/OVMS.V3/components/wolfssh/wolfssh (v1.4.10-stable)
  7c3878f8302c0e84578a67473e49e60bc6b3ada7 vehicle/OVMS.V3/components/zip/libzip (rel-1-5-1-60-g7c3878f)
  d6bcf4ca4d02479f058fff44cfd171f928148179 vehicle/OVMS.V3/components/zip/zlib (v1.2.11-65-gd6bcf4c)

In particular, you should have wolfssh at v1.4.10-stable

If not, please try both:
git submodule update --init --recursive
git submodule sync --recursive

If not, please be sure that you do all this in a separate fresh directory.


If a new user tries to compile from scratch, I believe it should work. 
(I've just tried it, and it "works for me")

The error you have seems to imply that wolfssh is not at the proper 
1.4.10 version but at a version >= 1.4.12

Let us know.

Regards,

Le 13/05/2023 à 19:59, Chris van der Meijden a écrit :
> Could you please explain in detail what I need to do?
>
> I tried to pull the code completely fresh from master. That does not work.
>
> What if a new user tries to compile from scratch? Will they run into 
> the same issues?
>
>
>
> Am Samstag, dem 13.05.2023 um 19:32 +0200 schrieb Ludovic LANGE:
>> Hi Chris,
>>
>> Yes we unfortunately had an issue where we merged, then reverted a patch.
>>
>> It seems that unfortunately it didn't work for you. Could you try to 
>> fetch, then reset your git repo to HEAD, it seems you did not fetch 
>> the "revert" patches ?
>>
>> Let us know.
>>
>> Le 13/05/2023 à 19:08, Chris van der Meijden a écrit :
>> Today I pulled the newest version. During the pull my Wolfssh 
>> directory was deleted. I then renewed all the submodules and I got 
>> the newest Wolfssh.
>>
>> But now the verion 3.3.003-467-ge7f41bd8-dirty won't compile (why is 
>> it "dirty" anyways, I didn't change the code ...).
>>
>> First I get
>>
>> CXX build/console_ssh/src/console_ssh.o
>> /home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/console_ssh/src/console_ssh.cpp: 
>> In function 'void wolfssh_logger(wolfSSH_LogLevel, const char*)':
>> /home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/console_ssh/src/console_ssh.cpp:1176:10: 
>> error: enumeration value 'WS_LOG_CERTMAN' not handled in switch 
>> [-Werror=switch]
>> switch (level)
>> ^
>>
>> Then I add case WS_LOG_CERTMAN: on line 1178:
>>
>> static void wolfssh_logger(enum wolfSSH_LogLevel level, const char* 
>> const msg)
>> {
>> switch (level)
>> {
>> case WS_LOG_CERTMAN:
>> ...
>>
>> But the I run into this error:
>>
>> /home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c: 
>> In function 'IdentifyKey':
>> /home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:883:9: 
>> warning: unused variable 'dynType' [-Wunused-variable]
>> int dynType = isPrivate ? DYNTYPE_PRIVKEY : DYNTYPE_PUBKEY;
>> ^
>> /home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c: 
>> In function 'DoKexDhReply':
>> /home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:3947:17: 
>> error: implicit declaration of function 'PRIVATE_KEY_UNLOCK' 
>> [-Werror=implicit-function-declaration]
>> PRIVATE_KEY_UNLOCK();
>> ^
>> /home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:3952:17: 
>> error: implicit declaration of function 'PRIVATE_KEY_LOCK' 
>> [-Werror=implicit-function-declaration]
>> PRIVATE_KEY_LOCK();
>> ^
>>
>> Any ideas?
>>
>> Regards Chris
>>
>>
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev at lists.openvehicles.com
>> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
>>
>>
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev at lists.openvehicles.com
>> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
>
>
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.openvehicles.com
> http://lists.openvehicles.com/mailman/listinfo/ovmsdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20230513/3b98b871/attachment-0001.htm>