[Ovmsdev] New pull requests pending

[Mark Webb-Johnson]

Yes, ^this.

The main repository master should be relatively stable. If we need something potentially breaking, or a major restructuring of how things are done, then we should do that in a main repository branch. That is the reason for the upcoming 3.3 branch (as it restructures the modem driver, which could be potentially very breaking - more on this later, when I am ready to release).

Preparing stuff for inclusion in the main repository should in general be done in local clone copies, then pull-requests made when ready.

Regards, Mark

> On 17 Aug 2020, at 1:08 PM, Soko <ovms at soko.cc> wrote:
> 
> PS: On a second thought I kinda cannot see the advantage of a PR request into a Dev branch in comparison into the master branch. 
> If the PR is changed and improved until it is approved by you guys it should be OK to go into the master. 
> 
> On 17 August 2020 07:00:37 CEST, Soko <ovms at soko.cc> wrote:
> Hi Derek. 
> 
> I would prefer the first option as discussing source is way easier on a PR in github as here in the mailing list. 
> 
> Soko
> 
> On 17 August 2020 06:53:40 CEST, Derek Caudwell <d.caudwell at gmail.com> wrote:
> Hi Mark,
> 
> Would it possible to have a 'Dev' branch in the main repository for those of us needing assistance to get a feature to the point it can be merged into the 'Master'? 
> 
> If that's not preferred and we use a branch on our own github clone, is it as simple as providing the link to the branch on this email list to invite others to collaborate/review? 
> 
> With the latter approach we may miss out on input from others not actively monitoring this forum I guess.
> 
> Regards Derek 
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.openvehicles.com
> http://lists.openvehicles.com/mailman/listinfo/ovmsdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20200817/6d7a7411/attachment.htm>