[Ovmsdev] Initial experience and Nissan Leaf updates

[Robin O'Leary]

On Thu, Apr 19, 2018 at 10:59:44PM +0200, Michael Balzer wrote:
> Am 19.04.2018 um 17:39 schrieb Robin O'Leary:
> > I would like to record the temperature inside the car, but I couldn't
> > see an appropriate metric (I've stuck it on ms_v_charge_temp for now).
> > Is there a better place for it?
> 
> There is ms_v_env_temp for the ambient temperature, but that's normally meant for the outside temperature I think.

Yes, ms_v_env_temp is already being used for that purpose.

> You can add a metric for that, i.e. ms_v_env_cabintemp / "v.e.cabintemp".

That seems simple enough... except adding a new standard metric looks
like it would have implications for the protocol in ovms_server_v2.cpp.

> > What is the intent of ms_v_env_on?  It was previously set true when
> > certain CAN traffic was present and false after a period of inactivity.
> > I now set it to true when the car is in state "ready to drive".
> >
> > A similar question goes for ms_v_env_awake.  I've left this doing the
> > CAN activity detection, which means it changes for minor things like
> > detecting a key-fob.
> 
> "awake" = Vehicle/bus awake (switched on)
> 
> "on" = "Ignition" state (drivable)

OK, that's what I assumed for 'on', but I thought I'd better ask advice
given this comment in vehicle_nissanleaf.cpp:

  // FIXME
  // detecting that on is stale and therefor should turn off probably shouldn't
  // be done like this
  // perhaps there should be a car on-off state tracker and event generator in
  // the core framework?
  // perhaps interested code should be able to subscribe to "onChange" and
  // "onStale" events for each metric?
 
> > What is the process for contributing changes?  I am currently doing
> > my local work on the master branch cloned from github.
> 
> Normal process is using Github pull requests. You push your commits to you repository, then create a pull request. We check your changes and merge them into the
> master.

OK, I have done that.

> You should coordinate your work with Tom Parker ("carrott"), the main developer of the Nissan Leaf adaption. To do so you can also add his repository and send
> pull requests to him (and vice versa).

Yes, I am also familiar with Tom's work from the mynissanleaf.com forum.
I think he has mostly been working with a different model year, so it
will be interesting to compare the differences between the two.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20180419/a0ddc25e/attachment-0002.sig>