I have noticed that many of the 1-second vehicle ticker functions decrement the stale counts... however looking at the code that is executed in vehicle.c just before dispatching to the vehicle-specific ticker code, it already decrements the stale counts! I think all the vehicle-specific ones should be removed. Matt Beard
Matt, Well spotted. You are right. It looks like it affects: vehicle_kyburz vehicle_mitsubishi vehicle_obdii vehicle_tazzari vehicle_thinkcity vehicle_voltampera I have removed the duplicate car_stale_* decrements from all the vehicle_*.c modules affected - please make sure you do the same in your local copies, or merge in my changes: * d111920 (HEAD, origin/master, origin/HEAD, master) Remove duplicate car_stale_* decrements in individual vehicle modules (as done centrally in vehicle.c) For Thomas Bergo's issue, and other cars dealing with the same issue, I think the best is to add the following to the vehicle ticker1 function: car_doors3bits.CoolingPump= (car_stale_temps<=1)?0:1; Regards, Mark. On 30 Oct, 2013, at 1:31 am, Matt Beard <matt@beard.tv> wrote:
I have noticed that many of the 1-second vehicle ticker functions decrement the stale counts... however looking at the code that is executed in vehicle.c just before dispatching to the vehicle-specific ticker code, it already decrements the stale counts!
I think all the vehicle-specific ones should be removed.
Matt Beard
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
participants (2)
-
Mark Webb-Johnson -
Matt Beard