PR review requests + Mongoose 7 progress update
Dear all,
I have a few PRs pending, that are low-risk I believe, but are building block for the ESP-IDF4+ upgrade saga:
ESP-IDFv4+: fix cmake build of ovms_webserver #907 <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/907>
specific to ESP-IDF4+ builds (for the ovms_webserver component): o It reverts a previous PR on the component.mk / ESP-IDF3 build system of this component - which had a temporary workaround o It fixes the ESP-IDF4+ build system of this component with an approach better aligned to the ESP-IDF3 approach.
mongoose: identify dependencies, and generate a version header #909 <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/909> o In order to help upgrade mongoose from 6.11 to 7.10, it introduces a new header with ability to compare mongoose version. It impacts both ESP3 and ESP4+ builds but should be low-impact
Also pending:
fix documentation of arguments of tcpserver #900 <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/900> straightforward update of the documentation
fix a few issues appearing when disabling/enabling components #910 <https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/910> o (specific to ESP-IDF4+) : make |ovms_plugins| compilable with or without |duktape| o |vehicle_hyundai_ioniq5| had issue when disabling webserver component o |vehicle_maxus_euniq56| had missing header when disabling webserver component
If some of you can review any or all of these it'll help.
Thank you !
Finally, progress is being made on the Mongoose v7.10 upgrade.
You can have a look at the upgrade-mongoose-7 branch
<https://github.com/llange/Open-Vehicle-Monitoring-System-3/tree/upgrade-mongoose-7>,
or this (artificial) PR
<https://github.com/llange/Open-Vehicle-Monitoring-System-3/pull/5/files>
to show the diff.
At the moment, SSH console is crashing. Not happy with that, and will happily read your comments about it.
Regards,
participants (1)
-
Ludovic LANGE