The original implementation was to use this in vehicle modules that required GPS from the modem (and not from car CAN bus signals): MyEvents.SignalEvent("vehicle.require.gps", NULL); MyEvents.SignalEvent("vehicle.require.gpstime", NULL); There was also the ‘modem’ ‘enable.gps’ and ‘enable.gpstime’ configuration. Reviewing the code now, I can’t see the implementation of this any more. We now seem to work solely from the ‘enable.gps’ and ‘enable.gpstime’ in the modem config. Any objections / suggestions to putting this back? Perhaps with a RegisterGPS(bool) and RegisterGPSTime(bool) in the vehicle base class, then have simcom GsmNMEA check the config and current vehicle - with config overriding vehicle preferences? Regards, Mark.
Mark, see https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/166 …and followup commits bbb6885ef0f045867a4aaf18488157a6f9de56ea & d28110930af98073d18368311e42a30e72a87387 tl;dr: the user should be in control over this (and now is). Regards, Michael Am 15.08.19 um 02:46 schrieb Mark Webb-Johnson:
The original implementation was to use this in vehicle modules that required GPS from the modem (and not from car CAN bus signals):
MyEvents.SignalEvent("vehicle.require.gps", NULL); MyEvents.SignalEvent("vehicle.require.gpstime", NULL);
There was also the ‘modem’ ‘enable.gps’ and ‘enable.gpstime’ configuration.
Reviewing the code now, I can’t see the implementation of this any more. We now seem to work solely from the ‘enable.gps’ and ‘enable.gpstime’ in the modem config.
Any objections / suggestions to putting this back? Perhaps with a RegisterGPS(bool) and RegisterGPSTime(bool) in the vehicle base class, then have simcom GsmNMEA check the config and current vehicle - with config overriding vehicle preferences?
Regards, Mark.
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
participants (2)
-
Mark Webb-Johnson -
Michael Balzer