Michael and Geir, Can you please see whether the definitions of MIN and MAX in your files are needed? These macros are defined in: esp-idf/components/newlib/include/sys/param.h which gets included from ovms_config.h and perhaps other places. When I'm compiling with release v3.0 the redefinition of these macros shows up as a warning. It would be possible to ignore the warning and it might also be possible to turn off the warnings by changing the configuration, but if the definitions are not needed this would be cleaner. -- Steve
Stephen, sys/param.h was not included previously. As the definitions match, I can use those. Or add an #ifndef / #undef. As you're compiling with v3 already: are the SD card issues solved with that release? Regards, Michael Am 04.01.2018 um 22:01 schrieb Stephen Casner:
Michael and Geir,
Can you please see whether the definitions of MIN and MAX in your files are needed? These macros are defined in:
esp-idf/components/newlib/include/sys/param.h
which gets included from ovms_config.h and perhaps other places.
When I'm compiling with release v3.0 the redefinition of these macros shows up as a warning. It would be possible to ignore the warning and it might also be possible to turn off the warnings by changing the configuration, but if the definitions are not needed this would be cleaner.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
Michael, Attached is the compilation log with v3.0 so you can see the include chain. Certainly this can be managed with #ifndef / #undef; I added #undef temporarily to make the warnings go away, but I thought there might be a cleaner solution. I'm exploring v3.0 at Mark's request so that we may be able to include the hardware module with additional RAM. My first step was just to work out the compilation issues. My task is to figure out how to implement or replace the "module memory" and "module tasks" commands that I implemented before with extra code added to esp-idf. I have not explored the SD card issues, but Mark has reported earlier on his tests with v3.0 and the alternative hardware module. -- Steve On Thu, 4 Jan 2018, Michael Balzer wrote:
Stephen,
sys/param.h was not included previously. As the definitions match, I can use those. Or add an #ifndef / #undef.
As you're compiling with v3 already: are the SD card issues solved with that release?
Regards, Michael
Am 04.01.2018 um 22:01 schrieb Stephen Casner:
Michael and Geir,
Can you please see whether the definitions of MIN and MAX in your files are needed? These macros are defined in:
esp-idf/components/newlib/include/sys/param.h
which gets included from ovms_config.h and perhaps other places.
When I'm compiling with release v3.0 the redefinition of these macros shows up as a warning. It would be possible to ignore the warning and it might also be possible to turn off the warnings by changing the configuration, but if the definitions are not needed this would be cleaner.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
Michael, Attached is the compilation log with v3.0 so you can see the include chain. Certainly this can be managed with #ifndef / #undef; I added #undef temporarily to make the warnings go away, but I thought there might be a cleaner solution. I'm exploring v3.0 at Mark's request so that we may be able to include the hardware module with additional RAM. My first step was just to work out the compilation issues. My task is to figure out how to implement or replace the "module memory" and "module tasks" commands that I implemented before with extra code added to esp-idf. I have not explored the SD card issues, but Mark has reported earlier on his tests with v3.0 and the alternative hardware module. -- Steve On Thu, 4 Jan 2018, Michael Balzer wrote:
Stephen,
sys/param.h was not included previously. As the definitions match, I can use those. Or add an #ifndef / #undef.
As you're compiling with v3 already: are the SD card issues solved with that release?
Regards, Michael
Am 04.01.2018 um 22:01 schrieb Stephen Casner:
Michael and Geir,
Can you please see whether the definitions of MIN and MAX in your files are needed? These macros are defined in:
esp-idf/components/newlib/include/sys/param.h
which gets included from ovms_config.h and perhaps other places.
When I'm compiling with release v3.0 the redefinition of these macros shows up as a warning. It would be possible to ignore the warning and it might also be possible to turn off the warnings by changing the configuration, but if the definitions are not needed this would be cleaner.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
Three reasons for working on IDF 3.0 now: We’ll need it for PSRAM support, should we go that route. It is the latest bootloader, and includes firmware checksum support (it is hard to OTA update the bootloader). If Espressif fix the SDCARD issue (assuming it is fixable in software), they will most likely fix it in that branch. We’re still working with Espressif on SDCARD vs flash >4MB. Response is less than exciting. They made a board to try to recreate the problem, but put a 4MB flash on it and not surprisingly couldn’t repeat the issue. We keep telling them to try with a 16MB flash, but it is like talking to a brick wall. Or perhaps a brick wall at the other end of a pitch black room with no echo. Very frustrating. Regards, Mark.
On 5 Jan 2018, at 5:20 AM, Michael Balzer <dexter@expeedo.de> wrote:
Stephen,
sys/param.h was not included previously. As the definitions match, I can use those. Or add an #ifndef / #undef.
As you're compiling with v3 already: are the SD card issues solved with that release?
Regards, Michael
Am 04.01.2018 um 22:01 schrieb Stephen Casner:
Michael and Geir,
Can you please see whether the definitions of MIN and MAX in your files are needed? These macros are defined in:
esp-idf/components/newlib/include/sys/param.h
which gets included from ovms_config.h and perhaps other places.
When I'm compiling with release v3.0 the redefinition of these macros shows up as a warning. It would be possible to ignore the warning and it might also be possible to turn off the warnings by changing the configuration, but if the definitions are not needed this would be cleaner.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
I sent a pull request with newest version for the Kia Soul. Have removed MIN and MAX and uses sys/param.h instead. Geir
5. jan. 2018 kl. 02:05 skrev Mark Webb-Johnson <mark@webb-johnson.net>:
Three reasons for working on IDF 3.0 now:
We’ll need it for PSRAM support, should we go that route. It is the latest bootloader, and includes firmware checksum support (it is hard to OTA update the bootloader). If Espressif fix the SDCARD issue (assuming it is fixable in software), they will most likely fix it in that branch.
We’re still working with Espressif on SDCARD vs flash >4MB. Response is less than exciting. They made a board to try to recreate the problem, but put a 4MB flash on it and not surprisingly couldn’t repeat the issue. We keep telling them to try with a 16MB flash, but it is like talking to a brick wall. Or perhaps a brick wall at the other end of a pitch black room with no echo. Very frustrating.
Regards, Mark.
<test_board.jpeg>
On 5 Jan 2018, at 5:20 AM, Michael Balzer <dexter@expeedo.de <mailto:dexter@expeedo.de>> wrote:
Stephen,
sys/param.h was not included previously. As the definitions match, I can use those. Or add an #ifndef / #undef.
As you're compiling with v3 already: are the SD card issues solved with that release?
Regards, Michael
Am 04.01.2018 um 22:01 schrieb Stephen Casner:
Michael and Geir,
Can you please see whether the definitions of MIN and MAX in your files are needed? These macros are defined in:
esp-idf/components/newlib/include/sys/param.h
which gets included from ovms_config.h and perhaps other places.
When I'm compiling with release v3.0 the redefinition of these macros shows up as a warning. It would be possible to ignore the warning and it might also be possible to turn off the warnings by changing the configuration, but if the definitions are not needed this would be cleaner.
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
participants (4)
-
Geir Øyvind Vælidalo -
Mark Webb-Johnson -
Michael Balzer -
Stephen Casner