It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so. Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend. Regards, Mark.
Mark, investigating David's issue (https://www.openvehicles.com/node/2484) I think I've just found a Mongoose bug. Testing a fix now, so we may be able to include that in the release. Regards, Michael Am 02.04.20 um 07:09 schrieb Mark Webb-Johnson:
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
Fix is pushed, everyone please remember doing a submodule update to fetch it. The bug prohibited the fallback for the mongoose connect option "server_name" of using the host name, which in turn meant the SNI wouldn't be sent, unless the application explicitly set a server_name. Regards, Michael Am 04.04.20 um 18:04 schrieb Michael Balzer:
Mark,
investigating David's issue (https://www.openvehicles.com/node/2484) I think I've just found a Mongoose bug.
Testing a fix now, so we may be able to include that in the release.
Regards, Michael
Am 02.04.20 um 07:09 schrieb Mark Webb-Johnson:
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
On 2020-04-04 10:09, Michael Balzer wrote:
Fix is pushed, everyone please remember doing a submodule update to fetch it.
What's the recommended way to do this? When I update my fork I run a script containing these commands: git fetch upstream git checkout master git submodule update git merge upstream/master git push but I checked and nothing in vehicle/OVMS.V3/components/mongoose/mongoose was updated so I went into that directory and: ice 1008 % git status On branch master Your branch is behind 'origin/master' by 6 commits, and can be fast-forwarded. (use "git pull" to update your local branch) nothing to commit, working tree clean so I'm clearly missing a step. Craig
I think this fixes it? Craig ice 139 % rcsdiff -u update.sh =================================================================== RCS file: RCS/update.sh,v retrieving revision 1.1 diff -u -r1.1 update.sh --- update.sh 2020/04/04 17:29:05 1.1 +++ update.sh 2020/04/04 17:29:11 @@ -2,6 +2,6 @@ set -x git fetch upstream git checkout master -git submodule update +git submodule update --recursive git merge upstream/master git push
Adding "--recursive" is recommended, but I think you really need to merge upstream/master before doing the submodule update. "submodule update" will update the submodules to the state as required by the current repository state. So you first need to update your branch or checkout an updated one. Regards, Michael Am 04.04.20 um 19:30 schrieb Craig Leres:
I think this fixes it?
Craig
ice 139 % rcsdiff -u update.sh =================================================================== RCS file: RCS/update.sh,v retrieving revision 1.1 diff -u -r1.1 update.sh --- update.sh 2020/04/04 17:29:05 1.1 +++ update.sh 2020/04/04 17:29:11 @@ -2,6 +2,6 @@ set -x git fetch upstream git checkout master -git submodule update +git submodule update --recursive git merge upstream/master git push
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
On 2020-04-04 10:52, Michael Balzer wrote:
Adding "--recursive" is recommended, but I think you really need to merge upstream/master before doing the submodule update.
"submodule update" will update the submodules to the state as required by the current repository state. So you first need to update your branch or checkout an updated one.
Am I not updating in the correct order? #!/bin/sh set -x git fetch upstream git checkout master git submodule update --recursive git merge upstream/master git push Should the submodule update go last? Craig
Last but one, after the merge: #!/bin/sh set -x git fetch upstream git checkout master git merge upstream/master git submodule update --recursive git push Regards, Michael Am 04.04.20 um 20:55 schrieb Craig Leres:
On 2020-04-04 10:52, Michael Balzer wrote:
Adding "--recursive" is recommended, but I think you really need to merge upstream/master before doing the submodule update.
"submodule update" will update the submodules to the state as required by the current repository state. So you first need to update your branch or checkout an updated one.
Am I not updating in the correct order?
#!/bin/sh set -x git fetch upstream git checkout master git submodule update --recursive git merge upstream/master git push
Should the submodule update go last?
Craig
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
OK. I’ve built 3.2.011 with this, and released to OTA. Regards, Mark.
On 5 Apr 2020, at 1:09 AM, Michael Balzer <dexter@expeedo.de> wrote:
Fix is pushed, everyone please remember doing a submodule update to fetch it.
The bug prohibited the fallback for the mongoose connect option "server_name" of using the host name, which in turn meant the SNI wouldn't be sent, unless the application explicitly set a server_name.
Regards, Michael
Am 04.04.20 um 18:04 schrieb Michael Balzer:
Mark,
investigating David's issue (https://www.openvehicles.com/node/2484) I think I've just found a Mongoose bug.
Testing a fix now, so we may be able to include that in the release.
Regards, Michael
Am 02.04.20 um 07:09 schrieb Mark Webb-Johnson:
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
Same on dexters-web. Btw, I'm not totally happy with my fix yet, as an IPv6 address may begin with a letter as well, and IP addresses should not be sent as SNI. I'll have another look at why mg_parse_address() doesn't return 0 for DNS names or if it really shouldn't do so, but that's not urgent. Regards, Michael Am 05.04.20 um 10:26 schrieb Mark Webb-Johnson:
OK. I’ve built 3.2.011 with this, and released to OTA.
Regards, Mark.
On 5 Apr 2020, at 1:09 AM, Michael Balzer <dexter@expeedo.de> wrote:
Fix is pushed, everyone please remember doing a submodule update to fetch it.
The bug prohibited the fallback for the mongoose connect option "server_name" of using the host name, which in turn meant the SNI wouldn't be sent, unless the application explicitly set a server_name.
Regards, Michael
Am 04.04.20 um 18:04 schrieb Michael Balzer:
Mark,
investigating David's issue (https://www.openvehicles.com/node/2484) I think I've just found a Mongoose bug.
Testing a fix now, so we may be able to include that in the release.
Regards, Michael
Am 02.04.20 um 07:09 schrieb Mark Webb-Johnson:
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev -- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
No issues reported from EAP, so I have today released this to MAIN (on api.openvehicles.com <http://api.openvehicles.com/>). Regards, Mark.
On 5 Apr 2020, at 4:26 PM, Mark Webb-Johnson <mark@webb-johnson.net> wrote:
OK. I’ve built 3.2.011 with this, and released to OTA.
Regards, Mark.
On 5 Apr 2020, at 1:09 AM, Michael Balzer <dexter@expeedo.de> wrote:
Fix is pushed, everyone please remember doing a submodule update to fetch it.
The bug prohibited the fallback for the mongoose connect option "server_name" of using the host name, which in turn meant the SNI wouldn't be sent, unless the application explicitly set a server_name.
Regards, Michael
Am 04.04.20 um 18:04 schrieb Michael Balzer:
Mark,
investigating David's issue (https://www.openvehicles.com/node/2484) I think I've just found a Mongoose bug.
Testing a fix now, so we may be able to include that in the release.
Regards, Michael
Am 02.04.20 um 07:09 schrieb Mark Webb-Johnson:
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
Same on dexters-web. Regards, Michael Am 14.04.20 um 07:55 schrieb Mark Webb-Johnson:
No issues reported from EAP, so I have today released this to MAIN (on api.openvehicles.com <http://api.openvehicles.com>).
Regards, Mark.
On 5 Apr 2020, at 4:26 PM, Mark Webb-Johnson <mark@webb-johnson.net <mailto:mark@webb-johnson.net>> wrote:
OK. I’ve built 3.2.011 with this, and released to OTA.
Regards, Mark.
On 5 Apr 2020, at 1:09 AM, Michael Balzer <dexter@expeedo.de <mailto:dexter@expeedo.de>> wrote:
Fix is pushed, everyone please remember doing a submodule update to fetch it.
The bug prohibited the fallback for the mongoose connect option "server_name" of using the host name, which in turn meant the SNI wouldn't be sent, unless the application explicitly set a server_name.
Regards, Michael
Am 04.04.20 um 18:04 schrieb Michael Balzer:
Mark,
investigating David's issue (https://www.openvehicles.com/node/2484) I think I've just found a Mongoose bug.
Testing a fix now, so we may be able to include that in the release.
Regards, Michael
Am 02.04.20 um 07:09 schrieb Mark Webb-Johnson:
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
Fixed. There was a bug in the unit conversion change for integer metrics. Regards, Michael Am 04.04.20 um 19:47 schrieb Thomas Heuer:
There is an bug in the edge version. See picture.
Von meinem Huawei-Telefon gesendet
-------- Ursprüngliche Nachricht -------- Von: Mark Webb-Johnson <mark@webb-johnson.net> Datum: Do., 2. Apr. 2020, 07:10 An: OVMS Developers <ovmsdev@lists.openvehicles.com> Betreff: [Ovmsdev] Ready for 3.2.011?
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
Sorry for that one. It was due to insufficient care when moving a change from one repo to another and, obviously, insufficient testing. -- Steve On Sat, 4 Apr 2020, Michael Balzer wrote:
Fixed. There was a bug in the unit conversion change for integer metrics.
Regards, Michael
Am 04.04.20 um 19:47 schrieb Thomas Heuer:
There is an bug in the edge version. See picture.
Von meinem Huawei-Telefon gesendet
-------- Ursprüngliche Nachricht -------- Von: Mark Webb-Johnson <mark@webb-johnson.net> Datum: Do., 2. Apr. 2020, 07:10 An: OVMS Developers <ovmsdev@lists.openvehicles.com> Betreff: [Ovmsdev] Ready for 3.2.011?
It is time for a 3.2.011 OTA release. Things seem stable for me now, and it would be good to get these releases out every month or so.
Is there anything else that needs to be in this? If so, please commit and/or pull request. I would like to get this release out to EAP over the weekend.
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
participants (5)
-
Craig Leres -
Mark Webb-Johnson -
Michael Balzer -
Stephen Casner -
Thomas Heuer