Just noticed... The Webserver restricts the vehicle ID to "upper case letters and digits". I thought underscores and dashes are allowed (seems to work); my car's ID contains an underscore... Is this additional restriction new (server v3, perhaps)? Greg
No, that's the v2 rule for vehicle IDs. Don't know about the origin though, I don't think any component would have a problem with lower case and dashes / underscores /… Even UTF-8 should be no problem (except via SMS). Maybe a rule we can drop? Am 08.03.2018 um 19:17 schrieb Greg D.:
Just noticed... The Webserver restricts the vehicle ID to "upper case letters and digits". I thought underscores and dashes are allowed (seems to work); my car's ID contains an underscore... Is this additional restriction new (server v3, perhaps)?
Greg
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
I can't find it now, but somehow I ended up with an underscore in my vehicle ID, registered through the OpenVehicles website. Should I change the ID, or change the webserver to accept the additional characters? I'm guessing the only real restrictions are to use the traditional printable characters from the base ASCII character set, and no spaces. Greg Michael Balzer wrote:
No, that's the v2 rule for vehicle IDs.
Don't know about the origin though, I don't think any component would have a problem with lower case and dashes / underscores /…
Even UTF-8 should be no problem (except via SMS). Maybe a rule we can drop?
Am 08.03.2018 um 19:17 schrieb Greg D.:
Just noticed... The Webserver restricts the vehicle ID to "upper case letters and digits". I thought underscores and dashes are allowed (seems to work); my car's ID contains an underscore... Is this additional restriction new (server v3, perhaps)?
Greg
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
As these are used in mDNS, I think we should follow DNS naming conventions: https://tools.ietf.org/html/rfc952 <https://tools.ietf.org/html/rfc952> https://technet.microsoft.com/en-us/library/cc959336.aspx <https://technet.microsoft.com/en-us/library/cc959336.aspx> I think that means letter, digits, and the hyphen character. Regards, Mark.
On 9 Mar 2018, at 3:42 AM, Greg D. <gregd2350@gmail.com> wrote:
I can't find it now, but somehow I ended up with an underscore in my vehicle ID, registered through the OpenVehicles website. Should I change the ID, or change the webserver to accept the additional characters? I'm guessing the only real restrictions are to use the traditional printable characters from the base ASCII character set, and no spaces.
Greg
Michael Balzer wrote:
No, that's the v2 rule for vehicle IDs.
Don't know about the origin though, I don't think any component would have a problem with lower case and dashes / underscores /…
Even UTF-8 should be no problem (except via SMS). Maybe a rule we can drop?
Am 08.03.2018 um 19:17 schrieb Greg D.:
Just noticed... The Webserver restricts the vehicle ID to "upper case letters and digits". I thought underscores and dashes are allowed (seems to work); my car's ID contains an underscore... Is this additional restriction new (server v3, perhaps)?
Greg
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
Right, forgot about that. Input validation rule changed to allow lower case letters and hyphen. Regards, Michael Am 09.03.2018 um 07:20 schrieb Mark Webb-Johnson:
As these are used in mDNS, I think we should follow DNS naming conventions:
https://tools.ietf.org/html/rfc952
https://technet.microsoft.com/en-us/library/cc959336.aspx
I think that means letter, digits, and the hyphen character.
Regards, Mark.
On 9 Mar 2018, at 3:42 AM, Greg D. <gregd2350@gmail.com <mailto:gregd2350@gmail.com>> wrote:
I can't find it now, but somehow I ended up with an underscore in my vehicle ID, registered through the OpenVehicles website. Should I change the ID, or change the webserver to accept the additional characters? I'm guessing the only real restrictions are to use the traditional printable characters from the base ASCII character set, and no spaces.
Greg
Michael Balzer wrote:
No, that's the v2 rule for vehicle IDs.
Don't know about the origin though, I don't think any component would have a problem with lower case and dashes / underscores /…
Even UTF-8 should be no problem (except via SMS). Maybe a rule we can drop?
Am 08.03.2018 um 19:17 schrieb Greg D.:
Just noticed... The Webserver restricts the vehicle ID to "upper case letters and digits". I thought underscores and dashes are allowed (seems to work); my car's ID contains an underscore... Is this additional restriction new (server v3, perhaps)?
Greg
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
I think it should accept and preserve mixed case IDs, but do case insensitive compares when matching IDs. I don’t want JoeSmithModelS showing up as JOESMITHMODELS. Tom From: <ovmsdev-bounces@lists.teslaclub.hk> on behalf of "Greg D." <gregd2350@gmail.com> Reply-To: OVMS Developers <ovmsdev@lists.teslaclub.hk> Date: Friday, March 9, 2018 at 11:26 AM To: OVMS Developers <ovmsdev@lists.teslaclub.hk> Subject: Re: [Ovmsdev] Valid Vehicle ID characters? But, the itef reference talks about there being no distinction between upper and lower case. Should we accept either, but shift (force) lower case to upper case? Greg Michael Balzer wrote: Right, forgot about that. Input validation rule changed to allow lower case letters and hyphen. Regards, Michael Am 09.03.2018 um 07:20 schrieb Mark Webb-Johnson: As these are used in mDNS, I think we should follow DNS naming conventions: https://tools.ietf.org/html/rfc952 https://technet.microsoft.com/en-us/library/cc959336.aspx I think that means letter, digits, and the hyphen character. Regards, Mark. On 9 Mar 2018, at 3:42 AM, Greg D. <gregd2350@gmail.com> wrote: I can't find it now, but somehow I ended up with an underscore in my vehicle ID, registered through the OpenVehicles website. Should I change the ID, or change the webserver to accept the additional characters? I'm guessing the only real restrictions are to use the traditional printable characters from the base ASCII character set, and no spaces. Greg Michael Balzer wrote: No, that's the v2 rule for vehicle IDs. Don't know about the origin though, I don't think any component would have a problem with lower case and dashes / underscores /… Even UTF-8 should be no problem (except via SMS). Maybe a rule we can drop? Am 08.03.2018 um 19:17 schrieb Greg D.: Just noticed... The Webserver restricts the vehicle ID to "upper case letters and digits". I thought underscores and dashes are allowed (seems to work); my car's ID contains an underscore... Is this additional restriction new (server v3, perhaps)? Greg _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev -- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26 _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
participants (4)
-
Greg D. -
Mark Webb-Johnson -
Michael Balzer -
Tom Saxton