When I'm working with my bench OVMS unit attached with USB and frequently rebooting, I don't want to have to log in each time. To avoid this I have patched console_async.cpp to SetSecure(true) in the constructor. But I have to be careful to omit that patched file when committing my changes. I proposed to add a Kconfig developer option to control whether that SetSecure(true) statement is included. Then I can commit this functionality into the code base where it will normally be excluded but can be included for a developer build configuration. This is similar to OVMS_DEV_CONFIGVFS option that allows read access to the ovms_config file. My proposed change is attached. Any objections? -- Steve
Steve, is there an issue or drawback with configuring an empty module password? Regards, Michael Am 25.01.21 um 01:53 schrieb Stephen Casner:
When I'm working with my bench OVMS unit attached with USB and frequently rebooting, I don't want to have to log in each time.
To avoid this I have patched console_async.cpp to SetSecure(true) in the constructor. But I have to be careful to omit that patched file when committing my changes. I proposed to add a Kconfig developer option to control whether that SetSecure(true) statement is included. Then I can commit this functionality into the code base where it will normally be excluded but can be included for a developer build configuration. This is similar to OVMS_DEV_CONFIGVFS option that allows read access to the ovms_config file.
My proposed change is attached. Any objections?
-- Steve
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
Answering myself, yes there is: web access is open then as well. No objections to your patch. Regards, Michael Am 25.01.21 um 07:49 schrieb Michael Balzer:
Steve,
is there an issue or drawback with configuring an empty module password?
Regards, Michael
Am 25.01.21 um 01:53 schrieb Stephen Casner:
When I'm working with my bench OVMS unit attached with USB and frequently rebooting, I don't want to have to log in each time.
To avoid this I have patched console_async.cpp to SetSecure(true) in the constructor. But I have to be careful to omit that patched file when committing my changes. I proposed to add a Kconfig developer option to control whether that SetSecure(true) statement is included. Then I can commit this functionality into the code base where it will normally be excluded but can be included for a developer build configuration. This is similar to OVMS_DEV_CONFIGVFS option that allows read access to the ovms_config file.
My proposed change is attached. Any objections?
-- Steve
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
This seems fine to me. The Component config > Open Vehicle Monitoring System (OVMS) > Developer Options Is the correct place to put it. Regards, Mark.
On 25 Jan 2021, at 8:53 AM, Stephen Casner <casner@acm.org> wrote:
When I'm working with my bench OVMS unit attached with USB and frequently rebooting, I don't want to have to log in each time.
To avoid this I have patched console_async.cpp to SetSecure(true) in the constructor. But I have to be careful to omit that patched file when committing my changes. I proposed to add a Kconfig developer option to control whether that SetSecure(true) statement is included. Then I can commit this functionality into the code base where it will normally be excluded but can be included for a developer build configuration. This is similar to OVMS_DEV_CONFIGVFS option that allows read access to the ovms_config file.
My proposed change is attached. Any objections?
-- Steve<secureasync.diff>_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
participants (3)
-
Mark Webb-Johnson -
Michael Balzer -
Stephen Casner