Changing Existing Functionalities
Hi, Already several times there have been instances where functionalities or existing metrics are changed and merged without reviews from previous developers. This leads to additional time of rolling back the changes when often the changes brake something for different model year cars. In turn this leads to more time spent on rolling back the changes and etc. Do we have some kind of guidlines to avoid this? Kind regards, Jaunius Sent using the GMX mail app
Jaunius, I've just commented on this topic here: https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/487#is... Git makes it totally simple to create public test branches that can be accessed by any developer. Pulling from another developer's repository is just a matter of adding that repository as a remote. Pull requests against the master should only be created when the code is meant to be rolled out to test users (on the "edge" release directory). Regards, Michael Am 12.12.20 um 10:36 schrieb jaunius@gmx.com:
Hi,
Already several times there have been instances where functionalities or existing metrics are changed and merged without reviews from previous developers. This leads to additional time of rolling back the changes when often the changes brake something for different model year cars. In turn this leads to more time spent on rolling back the changes and etc.
Do we have some kind of guidlines to avoid this?
Kind regards, Jaunius
Sent using the GMX mail app _______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
participants (2)
-
jaunius@gmx.com -
Michael Balzer