Hi All, In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between : * Kia eNero and Hyundai Kona ( console odometer is different PID location ) * Country ( console odometer can be in Miles or Kilometres ) * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right ) I'm wondering whats the best way to do this. I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could look at the VIN number to choose where to extract the odometer info. However I'm not sure on the others. I can't tell if the VIN number gives this level of detail. My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to fully decode the VIN for eNiro and Kona Electric. I guess the other option is to add some car specific features. Any ideas ? Thanks, Pete
Hi Pete I think the ODO can be solved with the VIN as you describe. Is the issue with the doors for both locked/unlocked and open/closed doors? For the doors and Miles/Km I think it would be best to have a config value. Med Vänlig Hälsning TIMO PENTTILÄ -----Original Message----- From: OvmsDev <ovmsdev-bounces@lists.openvehicles.com> On Behalf Of Peter Lord Sent: den 2 november 2019 10:47 To: OvmsDev@lists.openvehicles.com Subject: [Ovmsdev] Distinguishing between eNiro and Kona Hi All, In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between : * Kia eNero and Hyundai Kona ( console odometer is different PID location ) * Country ( console odometer can be in Miles or Kilometres ) * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right ) I'm wondering whats the best way to do this. I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could look at the VIN number to choose where to extract the odometer info. However I'm not sure on the others. I can't tell if the VIN number gives this level of detail. My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to fully decode the VIN for eNiro and Kona Electric. I guess the other option is to add some car specific features. Any ideas ? Thanks, Pete _______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
On 3 Nov 2019, at 13:27, Timo Penttilä <timo.penttila@codetap.se> wrote:
Hi Pete I think the ODO can be solved with the VIN as you describe.
Thanks.
Is the issue with the doors for both locked/unlocked and open/closed doors?
The app only shows car locked and unlocked, but I see : With the right hand side ( drivers side ) door open and the car unlocked.
For the doors and Miles/Km I think it would be best to have a config value.
Okay, thanks. I'll try and figure out how that works :-) Cheers, Pete
Med Vänlig Hälsning
TIMO PENTTILÄ
-----Original Message----- From: OvmsDev <ovmsdev-bounces@lists.openvehicles.com> On Behalf Of Peter Lord Sent: den 2 november 2019 10:47 To: OvmsDev@lists.openvehicles.com Subject: [Ovmsdev] Distinguishing between eNiro and Kona
Hi All,
In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between :
* Kia eNero and Hyundai Kona ( console odometer is different PID location ) * Country ( console odometer can be in Miles or Kilometres ) * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right )
I'm wondering whats the best way to do this.
I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could look at the VIN number to choose where to extract the odometer info.
However I'm not sure on the others. I can't tell if the VIN number gives this level of detail.
My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to fully decode the VIN for eNiro and Kona Electric.
I guess the other option is to add some car specific features.
Any ideas ?
Thanks,
Pete
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev _______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
In general, it is best to differentiate different models/features based on CAN bus traffic - although I realise that can be non-trivial at least when starting a project and only your own car’s logs to see. Perhaps others can collaborate with log captures from different variants? You can have a config-based override / setting for this. It is easy to check IsDefined for a particular config value, to see if the override is set. Regards, Mark.
On 2 Nov 2019, at 5:46 PM, Peter Lord <plord12@gmail.com> wrote:
Hi All,
In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between :
* Kia eNero and Hyundai Kona ( console odometer is different PID location ) * Country ( console odometer can be in Miles or Kilometres ) * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right )
I'm wondering whats the best way to do this.
I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could look at the VIN number to choose where to extract the odometer info.
However I'm not sure on the others. I can't tell if the VIN number gives this level of detail.
My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to fully decode the VIN for eNiro and Kona Electric.
I guess the other option is to add some car specific features.
Any ideas ?
Thanks,
Pete
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
On 4 Nov 2019, at 05:33, Mark Webb-Johnson <mark@webb-johnson.net> wrote:
In general, it is best to differentiate different models/features based on CAN bus traffic - although I realise that can be non-trivial at least when starting a project and only your own car’s logs to see. Perhaps others can collaborate with log captures from different variants?
Thanks - Googling I don't believe the VIN number has enough info, as you say trying to figure out much from OBD data is challenging to say the least :-) I do have the features I need implemented locally and it appears to work for what I need : I'll ponder this some more before creating a pull request.
You can have a config-based override / setting for this. It is easy to check IsDefined for a particular config value, to see if the override is set.
Regards, Mark.
On 2 Nov 2019, at 5:46 PM, Peter Lord <plord12@gmail.com> wrote:
Hi All,
In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between :
* Kia eNero and Hyundai Kona ( console odometer is different PID location ) * Country ( console odometer can be in Miles or Kilometres ) * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right )
I'm wondering whats the best way to do this.
I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could look at the VIN number to choose where to extract the odometer info.
However I'm not sure on the others. I can't tell if the VIN number gives this level of detail.
My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to fully decode the VIN for eNiro and Kona Electric.
I guess the other option is to add some car specific features.
Any ideas ?
Thanks,
Pete
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
Looks nice Pete. My only objection is that it should be the other way around. Km and left hand drive as default 😉. Med Vänlig Hälsning TIMO PENTTILÄ Systemtekniker/Utvecklare From: OvmsDev <ovmsdev-bounces@lists.openvehicles.com> On Behalf Of Peter Lord Sent: den 4 november 2019 20:26 To: OVMS Developers <ovmsdev@lists.openvehicles.com> Subject: Re: [Ovmsdev] Distinguishing between eNiro and Kona On 4 Nov 2019, at 05:33, Mark Webb-Johnson <mark@webb-johnson.net<mailto:mark@webb-johnson.net>> wrote: In general, it is best to differentiate different models/features based on CAN bus traffic - although I realise that can be non-trivial at least when starting a project and only your own car’s logs to see. Perhaps others can collaborate with log captures from different variants? Thanks - Googling I don't believe the VIN number has enough info, as you say trying to figure out much from OBD data is challenging to say the least :-) I do have the features I need implemented locally and it appears to work for what I need : [cid:image001.png@01D59350.17F533F0] I'll ponder this some more before creating a pull request. You can have a config-based override / setting for this. It is easy to check IsDefined for a particular config value, to see if the override is set. Regards, Mark. On 2 Nov 2019, at 5:46 PM, Peter Lord <plord12@gmail.com<mailto:plord12@gmail.com>> wrote: Hi All, In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between : * Kia eNero and Hyundai Kona ( console odometer is different PID location ) * Country ( console odometer can be in Miles or Kilometres ) * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right ) I'm wondering whats the best way to do this. I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could look at the VIN number to choose where to extract the odometer info. However I'm not sure on the others. I can't tell if the VIN number gives this level of detail. My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to fully decode the VIN for eNiro and Kona Electric. I guess the other option is to add some car specific features. Any ideas ? Thanks, Pete _______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com<mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev _______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com<mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
On 4 Nov 2019, at 19:41, Timo Penttilä <timo.penttila@codetap.se> wrote:
Looks nice Pete. My only objection is that it should be the other way around. Km and left hand drive as default 😉.
:-) Actually the default is ticked - picture was for my "minority" car with the defaults unticked.
Med Vänlig Hälsning
TIMO PENTTILÄ Systemtekniker/Utvecklare
From: OvmsDev <ovmsdev-bounces@lists.openvehicles.com <mailto:ovmsdev-bounces@lists.openvehicles.com>> On Behalf Of Peter Lord Sent: den 4 november 2019 20:26 To: OVMS Developers <ovmsdev@lists.openvehicles.com <mailto:ovmsdev@lists.openvehicles.com>> Subject: Re: [Ovmsdev] Distinguishing between eNiro and Kona
On 4 Nov 2019, at 05:33, Mark Webb-Johnson <mark@webb-johnson.net <mailto:mark@webb-johnson.net>> wrote:
In general, it is best to differentiate different models/features based on CAN bus traffic - although I realise that can be non-trivial at least when starting a project and only your own car’s logs to see. Perhaps others can collaborate with log captures from different variants?
Thanks - Googling I don't believe the VIN number has enough info, as you say trying to figure out much from OBD data is challenging to say the least :-)
I do have the features I need implemented locally and it appears to work for what I need :
I'll ponder this some more before creating a pull request.
You can have a config-based override / setting for this. It is easy to check IsDefined for a particular config value, to see if the override is set.
Regards, Mark.
On 2 Nov 2019, at 5:46 PM, Peter Lord <plord12@gmail.com <mailto:plord12@gmail.com>> wrote:
Hi All,
In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between :
* Kia eNero and Hyundai Kona ( console odometer is different PID location ) * Country ( console odometer can be in Miles or Kilometres ) * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right )
I'm wondering whats the best way to do this.
I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could look at the VIN number to choose where to extract the odometer info.
However I'm not sure on the others. I can't tell if the VIN number gives this level of detail.
My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to fully decode the VIN for eNiro and Kona Electric.
I guess the other option is to add some car specific features.
Any ideas ?
Thanks,
Pete
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
participants (3)
-
Mark Webb-Johnson -
Peter Lord -
Timo Penttilä