Pull request for Nissan Leaf
What to do with this? https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/113 OK to pull? Regards, Mark
On Thu, May 10, 2018 at 07:03:45PM +0800, Mark Webb-Johnson wrote:
What to do with this?
https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/113
OK to pull?
Tom commented favourably on an earlier version and I fixed the things he mentioned in <d6bb43fb-4f1f-509f-13e2-47c49edd7b87@carrott.org> but I'm not sure if he has looked at the latest version. I've been running it for a couple of days now and it seems to works nicely. Not sure if the VIN is any practical use, but the main point was to change from the custom code that could only do one poll type to the more general IncomingPollReply().
On 11/05/18 09:56, Robin O'Leary wrote:
On Thu, May 10, 2018 at 07:03:45PM +0800, Mark Webb-Johnson wrote:
What to do with this?
https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/113
OK to pull? Tom commented favourably on an earlier version and I fixed the things he mentioned in <d6bb43fb-4f1f-509f-13e2-47c49edd7b87@carrott.org> but I'm not sure if he has looked at the latest version.
I had not, I've just reviewed and approved the pull request, it looks good. I've also watched the project so I might get notified on your next pull request! I haven't had a chance to test it, but I'll try to do that shortly.
participants (3)
-
Mark Webb-Johnson -
Robin O'Leary -
Tom Parker