The reason to emit that event is to inform all potential listeners of the new state, so they can keep their internal state synchronized. Regards, Michael Am 19.12.20 um 19:09 schrieb Stephen Casner:
We don't need to emit the network.wifi.sta.bad event to cause WifiDisconnect() to be called because that is already happening. Is there some other reason for emitting that event?
-- Steve
On Sat, 19 Dec 2020, Michael Balzer wrote:
It's also the event emission, keeping the handling close together is for code readability. The compiler will probably inline that call anyway.
Regards, Michael
Am 19.12.20 um 18:32 schrieb Stephen Casner:
On Sat, 19 Dec 2020, Michael Balzer wrote:
If we need to force good/bad state, I suggest adding a method for this right after WifiStaCheckSQ(). Rather than just adding m_wifi_good = false in some place like WifiStaStop()? Another method doesn't seem warranted. That is a member variable, not something local to WifiStaCheckSQ().
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev -- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal Fon 02333 / 833 5735 * Handy 0176 / 206 989 26