On Fri, Apr 27, 2018 at 01:02:48PM +0100, Robin O'Leary wrote:
On Fri, Apr 27, 2018 at 10:01:32PM +1200, Tom Parker wrote:
You haven't changed my apparently overly complicated odometer code, does it work correctly with your car? Feel free to clean it up, and also the 0x5c0 mux issue, otherwise I'll do it later next week.
Yes, both are still on my to-do list; sorry, I've had limited time to go through those and the other things we discussed last week (SOC, SOH, temperature), but hope to catch up this weekend. It's probably best to keep them separate anyway, so it'll be easier to talk about one thing at a time.
I created a new pull request that includes the "ready to drive" detection, fixes ambient temperature conversion, narrows the multiplex check for battery temperature and simplifies the odometer code. It's funny; we now have plenty of temperature readings, but none of them exactly matched the car's display, which said 7°C! v.b.temp 9°C v.c.temp v.e.cabintemp 5.5°C v.e.temp 8°C v.i.temp 8°C v.m.temp