It looks workable to me. I have merged in the firmware pull request, and will leave the Android one up to Michael. Congratulations! Looking forward to seeing how this develops over time. Documentation has appeared online now: https://docs.openvehicles.com/en/latest/components/vehicle_vweup/docs/index.... <https://docs.openvehicles.com/en/latest/components/vehicle_vweup/docs/index.html> I think this should still be treated as experimental for the moment, until we have had time to get some experience with it. Regards, Mark.
On 18 Mar 2020, at 5:22 AM, Chris van der Meijden <chris@arachnon.de> wrote:
Dear all,
after some ups and downs I think we now have now enough functionality to officialy ask for commit to my pull request for integration of the VW e-Up to the OVMS master :-)
An overview of the supported and tested (yes, with a real VW e-Up :-)) features you can find here
https://github.com/devmarxx/Open-Vehicle-Monitoring-System-3/blob/master/veh... <https://github.com/devmarxx/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle_vweup/docs/index.rst>
I also added the car to the Android app. The app is working flawless with the car, so I believe that my pull request for the app also can be committed.
We will of course continue the development of our module. One major working area is still the remote climate control. This is more complicated than I hoped. We are now connected to the car directly through the comfort CAN bus to get easy access to some simple ID's. But we probably need to think about connecting to OBD for polling ID's for climate control and more battery information. This should preferably be done over bluetooth to avoid laying new wires in the car.
So therefor I would also like to ask for a brief status on bluetooth in OVMS. Bluetooth does not compile for me, but I just tried it once without getting into it deeper. At the moment I'm more focussed on "the great moment" of getting my pull request for the OMS master committed :-)
Looking forward to the next steps.
Regards
Chris
Am Sonntag, den 01.03.2020, 08:26 +0100 schrieb Chris van der Meijden:
Hi Michael,
thanx a lot for your nice and helpfull comments. I made some corrections.
Please feel free to take an other look at the code on future occasions. I really appreciate the remarks :-)
Greetinx
Chris
Am Samstag, den 29.02.2020, 17:05 +0100 schrieb Michael Balzer:
Chris,
some first comments: Please don't use TAB indentation, only spaces, or add a ".editorconfig". Tabs have different width depending on the editor & environment. Default indentation step for most of the code is two (2) spaces, except for some submodules (which have .editorconfig files as necessary, for example the zip module). See https://editorconfig.org/ <https://editorconfig.org/> ms_v_bat_12v_voltage is by default provided by the housekeeping from the OVMS ADC (supply voltage), there is currently no defined way to override this (maybe we should introduce one?). If you set the metric, you will let the CAN data fight against the ADC measurement (see housekeeping.cpp). The advantage of the ADC measurement is it works all the time, not only while the CAN bus is online. Checking ms_v_env_awake staleness to detect the switch-off will have a delay of 120 seconds, but I assume that's just a temporary solution. I bet there is some way to read the state from CAN. Overall, nice & clean & good remarks.
Btw, a typical CAN value scaling would be 100/256.
Regards, Michael
Am 26.02.20 um 09:07 schrieb Chris van der Meijden:
I do have some "first code" now.
We found some CAN-ID's for the e-Up, so we could start the work on some real functionality.
At this stage we have:
- SoC (hopefully) - VIN - Speed - 12 volt battery current
This should be enough to bring first action within the app, i.e. battery bar and parking notice.
I would like to invite you to take a look at the code here:
https://github.com/devmarxx/Open-Vehicle-Monitoring-System-3/blob/master/veh... <https://github.com/devmarxx/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle/vehicle.cpp>
and give me some feedback. I wrote the code "blind" and everything is untested because I don't have an OVMS v3 yet (it is on its way) and our e-Up has also not arrived yet (hoping for week 18 ...). So any hint on how to do better is welcome.
Thanx in advance.
Regards
Chris
Am Mittwoch, den 05.02.2020, 12:47 +0100 schrieb Chris van der Meijden:
It will take it's time though ...
At the moment I'm waiting for our e-Up to be delivered. Hopefully in April and that is where the real fun starts.
I forgot to mention my website with my experiences with OVMS for the Leaf and load of other stuff around e-mobility:
http://www.arachnon.de/wb/pages/en/nissan-leaf/ovms.php <http://www.arachnon.de/wb/pages/en/nissan-leaf/ovms.php>
Just to complete my introduction :-)
Chris
Am Mittwoch, den 05.02.2020, 12:20 +0100 schrieb Michael Balzer:
A quick addition:
Chris' work will be covering at least three new vehicles. The same vehicle drive train & electronics is used on… VW e-Up SEAT Mii electric ŠKODA CITIGOe iV …also called "the new trio". These are very attractive vehicles with a good balancing of price and capabilities, and very good efficiency.
It's quite possible the code can also partially be used on other VW vehicles (e-Golf, ID.3?), as VW tends to reuse components & protocols.
Regards, Michael
Am 05.02.20 um 10:44 schrieb Chris van der Meijden: > Dear OVMS-devs, > > my name is Chris van der Meijden (devmarxx) and I just started a new project on integrating the VW e-Up into OVMS. > > I mailed with Michael and he provided me with usefull procedure hints. I forked OVMS V3 and the Android code into my github account https://github.com/devmarxx?tab=repositories <https://github.com/devmarxx?tab=repositories> and commited my changes to the code there. I also started a pull request, but there is no hurry, because my vehicle code is just a template at the moment (like the Fiat 500 e code). The Android code is complete, but Michael is quite right that it would confuse the users to suddenly see the VW e-Up when there is still no functionality, so no hurry there too. > > My experience on OVMS so far is, that have been playing with the code for about 4 years. It started all because at that time I could not use the Android app on my Cyanogenmod phone due to the "google services" popup. I checked out the source code, removed the google check line and voila I could use the app with my Twizy and with my server :-) > > Later we bought a Nissan Leaf and I came in contact with Tom Parker. I had already set up the OVMS V2 toolchain, so it was very nice that I could use Tom's code to get the climate control of the Leaf to work. Always nice mail contact with Tom. Amazing the we can work together in New Zealand and Germany without ever have met. That where good times :-) > > So now we bought a VW e-Up, that will be delivered hopefully in April. So I thought now is a good time to get started with OVMS for the VW e-Up. I decided to connect to the vehicle not over the OBD connector, but through the OCU plug of the VW e-Up. By doing so I hope to bypass the complicated VW CAN TP2.0 protocoll and I will have direct access to the the VW comfort CAN. Time will tell if that is the right decission. > > I started a thread at the german goingelectric forum. Here I'll post my "adventures" (in German) and I hope to find some co-coders there too https://www.goingelectric.de/forum/viewtopic.php?f=50&t=54620 <https://www.goingelectric.de/forum/viewtopic.php?f=50&t=54620> > > Well .. So far my little introduction. > > Looking forward to do some happy coding together. > > Greetinx > > Chris > > _______________________________________________ > OvmsDev mailing list > OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> > http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
OvmsDev mailing list OvmsDev@lists.openvehicles.com <mailto:OvmsDev@lists.openvehicles.com> http://lists.openvehicles.com/mailman/listinfo/ovmsdev <http://lists.openvehicles.com/mailman/listinfo/ovmsdev>
OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev