Debugging this was simple. In gdb's stack trace, frame 0 pointed to the 'delete' in the destructor that referenced the invalid address due to the uninitialized value. -- Steve
On Oct 8, 2017, at 11:31 PM, Mark Webb-Johnson <mark@webb-johnson.net> wrote:
Steve,
You may have noticed that in 57aab41 I fixed the bug that caused the crash. The OvmsHttpClient::m_buf variable was not initialized.
Thanks for that. Nice find. Works for me:
Welcome to the Open Vehicle Monitoring System (OVMS) - Async Console OVMS > ota flash http Current running partition is: factory Target partition is: ota_0 Download firmware from api.openvehicles.com/firmware/ota/v3/main/ovms3.bin to ota_0 Error: Request failed W (7274) net: DNS lookup on api.openvehicles.com failed err=202
Feel bad about that one. I (almost) never do that (I push myself into the habit of adding initialisers and destructors when I create the member variable). Not sure how that slipped through, but it explains the weird stack mess.
OVMS > ota flash http OTA flash was successfull Flashed 927744 bytes from api.openvehicles.com/firmware/ota/v3/main/ovms3.bin Next boot will be from ‘ota_0'
Looks good! (apart from the spelling error, now fixed)
Regards, Mark.
On 9 Oct 2017, at 2:16 PM, Stephen Casner <casner@acm.org> wrote:
On Sun, 8 Oct 2017, Mark Webb-Johnson wrote:
I think that is because no network connection available (wifi). Can you try with wifi up, running, and an IP address assigned?
OVMS > ota flash http Current running partition is: factory Target partition is: ota_0 Download firmware from api.openvehicles.com/firmware/ota/v3/main/ovms3.bin to ota_0 Checksum is ae7b3ab032f6a5be7a8789650c76ea52 and expected file size is 927777 Preparing flash partition... Downloading... (100943 bytes so far) Downloading... (201095 bytes so far) Downloading... (301399 bytes so far) Downloading... (402139 bytes so far) Downloading... (502879 bytes so far) Downloading... (603771 bytes so far) Downloading... (704359 bytes so far) Downloading... (805099 bytes so far) Downloading... (905839 bytes so far) Download file length is 927744 and digest ae7b3ab032f6a5be7a8789650c76ea52 Setting boot partition... OTA flash was successfull Flashed 927744 bytes from api.openvehicles.com/firmware/ota/v3/main/ovms3.bin Next boot will be from 'ota_0'
Seems stack gets messed up in that case. I'll try to find out why, but the backtrace isn't helping much.
You may have noticed that in 57aab41 I fixed the bug that caused the crash. The OvmsHttpClient::m_buf variable was not initialized. Now without the wifi connection I get:
OVMS > ota flash http Current running partition is: factory Target partition is: ota_0 Download firmware from api.openvehicles.com/firmware/ota/v3/main/ovms3.bin to ota_0 Error: Request failed W (8297) net: DNS lookup on api.openvehicles.com failed err=202
-- Steve _______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev