Hi Mark, Yes, absolutely. In fact, I just thought of a corner case while nodding off to sleep (hate it when that happens!). Fixed, verified, and pushed to my branch. Anxiously awaiting review from Michael... Greg Mark Webb-Johnson wrote:
I think best for @michael to review. A single tx buffer is certainly easier to manage.
Regards, Mark.
On 16 Jan 2018, at 1:59 PM, Greg D. <gregd2350@gmail.com> wrote:
Mark Webb-Johnson wrote:
In vino veritas.
Indeed!
Fixes look good (can't seem to kill it). Pushed to my fork on Git Hub, along with removal of the delays in the obd2ecu.cpp code.
This was done on the older tool chain; wanted to be sure the fix was real before upgrading and potentially hiding the issue with a slight change in timing. Will upgrade the toolchain tomorrow and verify.
Greg
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev