Erick, welcome :) An initial PR for the initial vehicle support is OK. For later extensions, try to keep each PR concentrating on a specific feature/extension. Split up further on any critical change that may need to be quickly revertable. Keep framework and vehicle specific changes strictly separate, only include vehicle changes in framework commits if they need to be changed for the framework change. Use concise but clear commit messages. Do not submit unvalidated AI results. More: https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3?tab=readme-... Regards, Michael Am 02.02.26 um 04:23 schrieb Erick Fuentes via OvmsDev:
Hello!
I recently bought a 2019 eGolf and I'm interested in getting support for it in the project. Some folks on the OVMS Discord server have code that appears to work and I've volunteered to try to merge it. I've yet to run the code myself (I'm still waiting on a harness), but I thought I'd ask what the process might look like. Do you want small pull requests where each one covers a single, small feature? Are you okay with merging everything at once, provided it doesn't break other vehicles?
Erick
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- Michael Balzer * Am Rahmen 5 * D-58313 Herdecke Fon 02330 9104094 * Handy 0176 20698926