Is the poll functionality/framework in place, by the way?
Nope. And, I think that will have to be mine to do (as pretty fundamental) - unless someone else wants to step forward :-) What do people think of the v2 polling mechanism? Shall I just straight port it (moving to the object model, of course), or are there things we need to change/improve to make it more usable? Regards, Mark.
On 23 Oct 2017, at 2:05 PM, Geir Øyvind Vælidalo <geir@validalo.net> wrote:
Great! I missed the NL-part🙂
Is the poll functionality/framework in place, by the way?
Geir
Sendt fra min iPhone
23. okt. 2017 kl. 03:52 skrev Mark Webb-Johnson <mark@webb-johnson.net <mailto:mark@webb-johnson.net>>:
All good. I merged it, and changed NL->KS on line 41.
Regards, Mark.
On 23 Oct 2017, at 9:19 AM, Tom Parker <tom@carrott.org <mailto:tom@carrott.org>> wrote:
Hi Geir,
I see you've got Soule on line 41, and you've used the NL vehicle code on line 63 of vehicle_kiasoulev.cpp.
Otherwise it looks good.
I've been porting the Leaf v2 logic with as few changes as possible. The changes are mostly simple, replacement of can_databuffer with d and replacing the global state variables with metrics setters. I can still make sense of a diff between the v3 .cpp file and the v2 .c file. Once I have full feature parity between v2 and v3, I'll probably refactor the cpp code some.
On 23/10/17 09:50, Geir Øyvind Vælidalo wrote:
Mark,
I just sent a Pull request for the initial Kia Soul EV-stub. I’m still a newbie on GIT so forgive me if I make a mess! Most of the time spent so far is setting up esp-idf and trying to figure out GIT again 🙂
Geir
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev <http://lists.teslaclub.hk/mailman/listinfo/ovmsdev>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev <http://lists.teslaclub.hk/mailman/listinfo/ovmsdev>
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev <http://lists.teslaclub.hk/mailman/listinfo/ovmsdev>
OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev