In the cases I'm aware of, submodules are independent building blocks used by other projects. Our vehicle modules have many dependencies upon the core of the OVMS system. I'm not sure if that works. Also, if you want to make standard releases that support all the vehicles then you would be dependent upon the separate project owners to get their submodules ready. I assume that your motivation for considering this change is to avoid the load of be merging pull requests. I acknowledge the extra work, but in my view that extra level of filtering is often a good thing. -- Steve On Sun, 26 May 2019, Mark Webb-Johnson wrote:
Given that the vehicle modules in v3 are pretty independent, and don't seem to require any changes to the core code to implement (other than a Kconfig section, and a sub-directory in 'components'), I'm considering a structural change.
The proposal is to make each vehicle an independent GitHub repository, and to use the git submodule functionality to bring them in. The advantage there is that those projects can be split off and maintained by different people. Project owners, looking after their own vehicle types, could directly commit to their own vehicle modules, without requiring this to be centrally managed.
What do people think? Is that a sensible way of doing this?
Regards, Mark.
_______________________________________________ OvmsDev mailing list OvmsDev@lists.openvehicles.com http://lists.openvehicles.com/mailman/listinfo/ovmsdev