Re: [Ovmsdev] New can logging

On 2019-07-28 04:10, Mark Webb-Johnson wrote:

I tried some more. It seems that the problem is with logging errors in crtd format. I didn’t see it because my bus had no errors.

Seems to be just a simple buffer overflow. I’ve committed a fix.

Regards, Mark.

P.S. I have a relatively big update to can logging going through testing. Some standardisation of functionality for incoming data (such as whether to transmit or simulate it), and a can log playback system.

Would it be ok to stop using sprintf() completely? Personally I try and use snprintf() and strlcpy() instead of sprintf() and strcpy(). Craig