Chris, Am 04.02.25 um 23:49 schrieb Chris Box:
Am 15.01.25 um 11:11 schrieb Michael Balzer via OvmsDev:
Speaking of the Leaf, the code there actually does something fishy in `CommandWakeup()`:
unsigned char data = 0; ... m_can1->WriteStandard(0x5C0, *_8_*, &data); //Wakes up the VCM (by spoofing empty battery request heating) I agree that is dodgy. It's going to write 8 bytes of data onto the bus, but only the first byte's contents are known. The other 7 are nondeterministic - just whatever happened to be on the stack at that time. This doesn't seem like a recipe for predictable operation.
I'd say that seems like a recipe for an occasional car fault condition. If the message needs to be 8 bytes long, I'd expect the car to normally also process all 8 bytes.
The commit was https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commit/09c5... by dalathegreat. Unfortunately my CAN knowledge is close to zero so I can't comment on the messages themselves.
You could try if the 8 is the error here by replacing that by 1, and if that then no longer works, you could try making data a deterministic 8 null bytes frame. Regards, Michael -- Michael Balzer * Am Rahmen 5 * D-58313 Herdecke Fon 02330 9104094 * Handy 0176 20698926