[Ovmsdev] [cesanta/mongoose] LWIP SO_REUSEADDR & ESP32 logging (#894) (fwd)
mark at webb-johnson.net
Thu Feb 13 07:53:26 HKT 2020
It is ridiculous. I replied as follows:
> This PR contains several unrelated pieces - please split, one PR per single functionality piece. The PR should be against the dev branch, and one PR must have only one commit.
Is there any point? There are 33 pull requests here, dating back to 5 years to 2015. Only three have any response, and this one has sat dead since October 2018. It seems Cesanta is simply not interested in community improvements? We could go to the work to re-factor all these improvements and bug fixes into individual PRs, but there seems little point unless they get some attention.
The way we are making our changes, to mongoose.h and mongoose.c directly, isn’t really compatible with how they do things anyway. We should probably be using their tools/(un)amalgam.py scripts.
Let’s see what they reply (to my somewhat rude comment), and go from there. There are so few changes been made to cesanta/mongoose that it may just be easier for us to pull from them.
> On 13 Feb 2020, at 4:49 AM, Stephen Casner <casner at acm.org> wrote:
> What happened? Did Mark's commit 58942ce96c5e3e14edb53c804ffcdd4127e226e7
> finally wake up cesanta? Are we going to resubmit all of our changes
> as separate pull requests? One person does that, or each author? And
> to the extent that they may be interdependent, so we need for them to
> be accepted in order?
> -- Steve
> ---------- Forwarded message ----------
> Date: Wed, 12 Feb 2020 01:35:43 -0800
> From: Sergey Lyubka <notifications at github.com>
> Reply-To: cesanta/mongoose
> <reply+ABG5G6FIED7L3BL25LSLI4F4KD4W7EVBNHHBDAFYO4 at reply.github.com>
> To: cesanta/mongoose <mongoose at noreply.github.com>
> Cc: Stephen Casner <casner at acm.org>, Mention <mention at noreply.github.com>
> Subject: Re: [cesanta/mongoose] LWIP SO_REUSEADDR & ESP32 logging (#894)
> This PR contains several unrelated pieces - please split, one PR per single functionality piece. The PR should be against the `dev` branch, and one PR must have only one commit.
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> OvmsDev mailing list
> OvmsDev at lists.openvehicles.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OvmsDev