[Ovmsdev] Distinguishing between eNiro and Kona

[Peter Lord]

> On 4 Nov 2019, at 05:33, Mark Webb-Johnson <mark at webb-johnson.net> wrote:
> 
> In general, it is best to differentiate different models/features based on CAN bus traffic - although I realise that can be non-trivial at least when starting a project and only your own car’s logs to see. Perhaps others can collaborate with log captures from different variants?


Thanks - Googling I don't believe the VIN number has enough info, as you say trying to figure out much from OBD data is challenging to say the least :-)

I do have the features I need implemented locally and it appears to work for what I need :




I'll ponder this some more before creating a pull request.



> 
> You can have a config-based override / setting for this. It is easy to check IsDefined for a particular config value, to see if the override is set.
> 
> Regards, Mark.
> 
>> On 2 Nov 2019, at 5:46 PM, Peter Lord <plord12 at gmail.com> wrote:
>> 
>> Hi All,
>> 
>> In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between :
>> 
>> * Kia eNero and Hyundai Kona ( console odometer is different PID location )
>> * Country ( console odometer can be in Miles or Kilometres )
>> * Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right )
>> 
>> I'm wondering whats the best way to do this.
>> 
>> I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could
>> look at the VIN number to choose where to extract the odometer info.
>> 
>> However I'm not sure on the others.  I can't tell if the VIN number gives this level of detail.
>> 
>> My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to
>> fully decode the VIN for eNiro and Kona Electric.
>> 
>> I guess the other option is to add some car specific features.
>> 
>> Any ideas ?
>> 
>> Thanks,
>> 
>> Pete
>> 
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev at lists.openvehicles.com
>> http://lists.openvehicles.com/mailman/listinfo/ovmsdev
> 
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.openvehicles.com
> http://lists.openvehicles.com/mailman/listinfo/ovmsdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20191104/7da24a78/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot 2019-11-04 at 19.23.50.png
Type: image/png
Size: 58357 bytes
Desc: not available
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20191104/7da24a78/attachment-0002.png>