<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 4 Nov 2019, at 05:33, Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net" class="">mark@webb-johnson.net</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">In general, it is best to differentiate different models/features based on CAN bus traffic - although I realise that can be non-trivial at least when starting a project and only your own car’s logs to see. Perhaps others can collaborate with log captures from different variants?<br class=""></div></div></blockquote><div><br class=""></div><div><br class=""></div>Thanks - Googling I don't believe the VIN number has enough info, as you say trying to figure out much from OBD data is challenging to say the least :-)</div><div><br class=""></div><div>I do have the features I need implemented locally and it appears to work for what I need :</div><div><br class=""></div><div><img apple-inline="yes" id="9057A793-D911-4FCD-AAB8-95A7C8D86250" src="cid:4E2416E5-8BF3-4245-9861-F12ECEA32358@plord.co.uk" class=""></div><div><br class=""></div><div><br class=""></div><div>I'll ponder this some more before creating a pull request.</div><div><br class=""></div><div><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">You can have a config-based override / setting for this. It is easy to check IsDefined for a particular config value, to see if the override is set.<br class=""><br class="">Regards, Mark.<br class=""><br class=""><blockquote type="cite" class="">On 2 Nov 2019, at 5:46 PM, Peter Lord <<a href="mailto:plord12@gmail.com" class="">plord12@gmail.com</a>> wrote:<br class=""><br class="">Hi All,<br class=""><br class="">In trying to get my UK Kona Electric working I've realised that in the eNiro code we need to distinguish between :<br class=""><br class="">* Kia eNero and Hyundai Kona ( console odometer is different PID location )<br class="">* Country ( console odometer can be in Miles or Kilometres )<br class="">* Left hand drive and right hand drive ( door PID's are associated with driver position not fixed left/right )<br class=""><br class="">I'm wondering whats the best way to do this.<br class=""><br class="">I believe the VIN number can tell us the first one - Hyundai is KMH and Kia KN, so the odometer code could<br class="">look at the VIN number to choose where to extract the odometer info.<br class=""><br class="">However I'm not sure on the others. I can't tell if the VIN number gives this level of detail.<br class=""><br class="">My UK Kona ( right hand dive, uses miles ) VIN starts with KMHK581GUKU - but I've not found a definitive way to<br class="">fully decode the VIN for eNiro and Kona Electric.<br class=""><br class="">I guess the other option is to add some car specific features.<br class=""><br class="">Any ideas ?<br class=""><br class="">Thanks,<br class=""><br class="">Pete<br class=""><br class="">_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.openvehicles.com" class="">OvmsDev@lists.openvehicles.com</a><br class="">http://lists.openvehicles.com/mailman/listinfo/ovmsdev<br class=""></blockquote><br class="">_______________________________________________<br class="">OvmsDev mailing list<br class=""><a href="mailto:OvmsDev@lists.openvehicles.com" class="">OvmsDev@lists.openvehicles.com</a><br class="">http://lists.openvehicles.com/mailman/listinfo/ovmsdev<br class=""></div></div></blockquote></div><br class=""></body></html>