[Ovmsdev] Fwd: [openvehicles/Open-Vehicle-Monitoring-System-3] 14d168: Fix building with webserver component

[Michael Balzer]

My fault and not platform dependant, sorry. My primary goal was building without the component for #189, I forgot to test building with it afterwards.


Am 27.01.19 um 08:45 schrieb Mark Webb-Johnson:
>
> My build system reported problems building overnight. I think the issue is:
>
>     * 8c0d6af2 Fix building without webserver component
>
>
> Four vehicle modules (Mitsubishi, Thinkcity, KiaSoul, and Twizy) complained with:
>
>         libvehicle_kiasoulev.a(vehicle_kiasoulev.o):(.literal._ZN20OvmsVehicleKiaSoulEvC2Ev+0x2ac): undefined reference to `OvmsVehicleKiaSoulEv::WebInit()'
>         vehicle_kiasoulev.cpp:1212: undefined reference to `OvmsVehicleKiaSoulEv::WebInit()'
>         libvehicle_kiasoulev.a(vehicle_kiasoulev.o):(.rodata._ZTV20OvmsVehicleKiaSoulEv[vtable for OvmsVehicleKiaSoulEv]+0xd8): undefined reference to
>         `OvmsVehicleKiaSoulEv::GetDashboardConfig(DashboardConfig&)'
>
>
> I think the issue is that the CONFIG_ defines are not available unless <sdkconfig.h> is included. Maybe platform dependent? Other include files bring that in,
> so this issue doesn’t happen all the time. Here is the fix:
>
>     #include <sdkconfig.h>
>     #ifdef CONFIG_OVMS_COMP_WEBSERVER
>
>
> I’ve committed the fix to the four vehicle modules, and now working ok for me.
>
> Regards, Mark.
>
>> Begin forwarded message:
>>
>> *From: *GitHub <noreply at github.com <mailto:noreply at github.com>>
>> *Subject: **[openvehicles/Open-Vehicle-Monitoring-System-3] 14d168: Fix building with webserver component*
>> *Date: *27 January 2019 at 3:40:02 PM HKT
>> *To: *mark at webb-johnson.net <mailto:mark at webb-johnson.net>
>> *Reply-To: *GitHub <noreply at github.com <mailto:noreply at github.com>>
>>
>>  Branch: refs/heads/master
>>  Home:   https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3
>>  Commit: 14d16854082fd2772af823af86b2185d76b64fc0
>>      https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commit/14d16854082fd2772af823af86b2185d76b64fc0
>>  Author: Mark Webb-Johnson <mark at webb-johnson.net <mailto:mark at webb-johnson.net>>
>>  Date:   2019-01-27 (Sun, 27 Jan 2019)
>>
>>  Changed paths:
>>    M vehicle/OVMS.V3/components/vehicle_kiasoulev/src/ks_web.cpp
>>    M vehicle/OVMS.V3/components/vehicle_mitsubishi/src/mi_web.cpp
>>    M vehicle/OVMS.V3/components/vehicle_renaulttwizy/src/rt_web.cpp
>>    M vehicle/OVMS.V3/components/vehicle_thinkcity/src/tc_web.cpp
>>
>>  Log Message:
>>  -----------
>>  Fix building with webserver component
>>
>>
>>
>>      **NOTE:** GitHub Services has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
>>
>>      We will provide an alternative path for the email notifications by January 31st, 2019.
>
>
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.openvehicles.com
> http://lists.openvehicles.com/mailman/listinfo/ovmsdev

-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20190127/c10f91d0/attachment.htm>