<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
My fault and not platform dependant, sorry. My primary goal was
building without the component for #189, I forgot to test building
with it afterwards.<br>
<br>
<br>
<div class="moz-cite-prefix">Am 27.01.19 um 08:45 schrieb Mark
Webb-Johnson:<br>
</div>
<blockquote type="cite"
cite="mid:8F362B68-B38A-4109-B3EB-10AE0AA4B22E@webb-johnson.net">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class=""><br class="">
</div>
<div class="">My build system reported problems building
overnight. I think the issue is:</div>
<div class=""><br class="">
</div>
<blockquote style="margin: 0 0 0 40px; border: none; padding:
0px;" class="">
<div class=""><font class="" face="Andale Mono"><span
style="font-size: 12px;" class="">* 8c0d6af2 Fix building
without webserver component</span></font></div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">Four vehicle modules (Mitsubishi, Thinkcity,
KiaSoul, and Twizy) complained with:</div>
<div class=""><br class="">
</div>
<blockquote style="margin: 0 0 0 40px; border: none; padding:
0px;" class="">
<blockquote style="margin: 0 0 0 40px; border: none; padding:
0px;" class="">
<div class=""><font class="" face="Andale Mono"><span
style="font-size: 12px;" class="">libvehicle_kiasoulev.a(vehicle_kiasoulev.o):(.literal._ZN20OvmsVehicleKiaSoulEvC2Ev+0x2ac):
undefined reference to `OvmsVehicleKiaSoulEv::WebInit()'</span></font></div>
<div class=""><font class="" face="Andale Mono"><span
style="font-size: 12px;" class="">vehicle_kiasoulev.cpp:1212:
undefined reference to `OvmsVehicleKiaSoulEv::WebInit()'</span></font></div>
<div class=""><font class="" face="Andale Mono"><span
style="font-size: 12px;" class="">libvehicle_kiasoulev.a(vehicle_kiasoulev.o):(.rodata._ZTV20OvmsVehicleKiaSoulEv[vtable
for OvmsVehicleKiaSoulEv]+0xd8): undefined reference to
`OvmsVehicleKiaSoulEv::GetDashboardConfig(DashboardConfig&)'</span></font></div>
</blockquote>
</blockquote>
<div class=""><br class="">
</div>
<div class="">I think the issue is that the CONFIG_ defines are
not available unless <sdkconfig.h> is included. Maybe
platform dependent? Other include files bring that in, so this
issue doesn’t happen all the time. Here is the fix:</div>
<div class=""><br class="">
</div>
<blockquote style="margin: 0 0 0 40px; border: none; padding:
0px;" class="">
<div class=""><font class="" size="2" face="Andale Mono">#include
<sdkconfig.h></font></div>
<div class=""><font class="" size="2" face="Andale Mono">#ifdef
CONFIG_OVMS_COMP_WEBSERVER</font></div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">I’ve committed the fix to the four vehicle modules,
and now working ok for me.</div>
<div class=""><br class="">
</div>
<div class="">Regards, Mark.</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">Begin forwarded message:</div>
<br class="Apple-interchange-newline">
<div style="margin-top: 0px; margin-right: 0px; margin-bottom:
0px; margin-left: 0px;" class=""><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b
class="">From: </b></span><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif;" class="">GitHub <<a
href="mailto:noreply@github.com" class=""
moz-do-not-send="true">noreply@github.com</a>><br
class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom:
0px; margin-left: 0px;" class=""><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b
class="">Subject: </b></span><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif;" class=""><b class="">[openvehicles/Open-Vehicle-Monitoring-System-3]
14d168: Fix building with webserver component</b><br
class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom:
0px; margin-left: 0px;" class=""><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b
class="">Date: </b></span><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif;" class="">27 January 2019 at 3:40:02 PM HKT<br
class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom:
0px; margin-left: 0px;" class=""><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b
class="">To: </b></span><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif;" class=""><a
href="mailto:mark@webb-johnson.net" class=""
moz-do-not-send="true">mark@webb-johnson.net</a><br
class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom:
0px; margin-left: 0px;" class=""><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b
class="">Reply-To: </b></span><span style="font-family:
-webkit-system-font, Helvetica Neue, Helvetica,
sans-serif;" class="">GitHub <<a
href="mailto:noreply@github.com" class=""
moz-do-not-send="true">noreply@github.com</a>><br
class="">
</span></div>
<br class="">
<div class="">
<div class=""> Branch: refs/heads/master<br class="">
Home: <a
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3"
class="" moz-do-not-send="true">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3</a><br
class="">
Commit: 14d16854082fd2772af823af86b2185d76b64fc0<br
class="">
<a
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commit/14d16854082fd2772af823af86b2185d76b64fc0"
class="" moz-do-not-send="true">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commit/14d16854082fd2772af823af86b2185d76b64fc0</a><br
class="">
Author: Mark Webb-Johnson <<a
href="mailto:mark@webb-johnson.net" class=""
moz-do-not-send="true">mark@webb-johnson.net</a>><br
class="">
Date: 2019-01-27 (Sun, 27 Jan 2019)<br class="">
<br class="">
Changed paths:<br class="">
M
vehicle/OVMS.V3/components/vehicle_kiasoulev/src/ks_web.cpp<br
class="">
M
vehicle/OVMS.V3/components/vehicle_mitsubishi/src/mi_web.cpp<br
class="">
M
vehicle/OVMS.V3/components/vehicle_renaulttwizy/src/rt_web.cpp<br
class="">
M
vehicle/OVMS.V3/components/vehicle_thinkcity/src/tc_web.cpp<br
class="">
<br class="">
Log Message:<br class="">
-----------<br class="">
Fix building with webserver component<br class="">
<br class="">
<br class="">
<br class="">
**<a class="moz-txt-link-freetext" href="NOTE:**">NOTE:**</a> GitHub Services has been marked for
deprecation: <a
href="https://developer.github.com/changes/2018-04-25-github-services-deprecation/"
class="" moz-do-not-send="true">https://developer.github.com/changes/2018-04-25-github-services-deprecation/</a><br
class="">
<br class="">
We will provide an alternative path for the email
notifications by January 31st, 2019.<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
OvmsDev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a>
<a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="160">--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
</pre>
</body>
</html>