[Ovmsdev] Poor wifi performance

[Mark Webb-Johnson]

Still not working for me. I get:

“Password:” overwriting “OVMS>” when I type “enable”.
First line of output overwrites command prompt whenever I type a command.
Pressing ENTER at “OVMS#” prompt seemingly does nothing.

Looking through the code, we send \n, not \r\n, in multiple places (for example in ovms_command.cpp enableInsert() function that handles password entry. A ‘find in project’ for \n shows 11,350 results! Simple_monitor works just fine.

Regards, Mark.

> On 10 Jul 2018, at 4:35 AM, Stephen Casner <casner at acm.org> wrote:
> 
> This problem of no newline is related to the somewhat tricky way I
> implemented alert output being written above the current command input
> line.  I truncate the newline from the last or only line of an alert
> message so that when it is followed by microrl putting out a new
> prompt, which is preceded by a newline, we don't get a blank line.
> 
> I've just committed a fix.  The problem was that the terminal monitor
> discards a newline that does not follow carriage return, and microrl's
> terminal_newline() function was written to output the same string to
> go to the next line as it takes for input to indicate the end of a
> command.  We need the input end-of-line to be just a newline
> character, so that is all that terminal_newline() put out before the
> prompt.  My fix was to change terminal_newline() to output the
> explicit string "\r\n" rather than the macro ENDL.
> 
>                                                        -- Steve
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.openvehicles.com
> http://lists.openvehicles.com/mailman/listinfo/ovmsdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20180710/3ee845bc/attachment.htm>