[Ovmsdev] Kia Soul Pull request

[Mark Webb-Johnson]

Geir,

Thanks for this.

Your code on the Kia Soul looks fine. Let me try to merge it in.

For the iOS App, best to send the pull request then we can look at it and see the impact.

Regards, Mark.

> On 7 Apr 2016, at 10:04 PM, Geir Øyvind Vælidalo <geir at validalo.net> wrote:
> 
> Hi guys,
> 
> I’ve sent a pull request for the newest Kia Soul-version. I want to do more, but at the moment my time is insufficient, so I thought it was as good time as any to get mye code into the master repository. Maybe someone else can do some good.
> 
> There are definitively bugs there, but I’ve been running on this version for a few months, so I haven’t broken anything important, I think :-D
> 
> Also, I hope that I haven’t made to much mess in the project! I’m sort of proud of what I have managed even though this have been a trial and error-kind of project on my part ;-)
> 
> I’ve done some playing around with the iOS-app too. Fixed some issues with the newer Xcode/iOS-version and added some things I thought was interesting to have, mainly because I needed to play around to try to understand Xcode and the app-itself. I’m not sure if I should send a pull request for that code, as the iOS-version will differ more from the android-version.
> 
> I’ve added this:
> 	- aux-battery voltage in the car-screen
> 	- When charging, it displays:
> 		- minutes remaining
> 		- minutes charged
> 		- kWh charged
> 		- Charging speed in kW.
> 
> What do you think? Should I check in and send a pull request for that too?
> 
> Best regards,
> Geir 
> 
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.teslaclub.hk
> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev