[Ovmsdev] Comments on Tazzari Firmware

[Patrick Kapsch]

Mark,
if car_chargestate will still have the value 4 when it comes from 0x04 to 0x63 then charge done seems correct.
I don't quite get the else if part. What does chargestate 21 represent? And if we don't come from 0x04 it has to be an interruption and therefore needs no further check with chargestate or chargesubstate, does it? I guess I'm missing something here.

Patrick


Am 14.04.2013 um 16:06 schrieb Mark Webb-Johnson <mark at webb-johnson.net>:

> Patrick,
> 
> There shouldn't be any 'charge complete' notifications - only 'charge interrupted':
> 
> Current logic is:
> 
>           case 0x63: // Charge done/failed (depending where we came from)
>             car_doors1 &= ~0x0c;    // Clear charge and pilot bits
>             car_chargemode = 0;     // Standard charge mode
>             car_charge_b4 = 0;      // Not required
>             if (car_chargestate == 4)
>               { // Charge done
>               }
>             else if (car_chargestate != 21)
>               { // Charge interrupted
>               car_chargestate = 21;    // Charge STOPPED
>               car_chargesubstate = 14; // Charge INTERRUPTED
>               net_req_notification(NET_NOTIFY_CHARGE);
>               }
>             break;
> 
> PID 0xFDE0 shows 8bit value 0x63 and car_chargestate != 4 and car_chargestate != 21, then we treat that as a charge interrupted and alert appropriately.
> 
> Does that seem correct? I'll have to check through the logs you made to double-check.
> 
> Regards, Mark.
> 
> On 14 Apr, 2013, at 5:53 AM, Patrick Kapsch <patrick.kapsch at mac.com> wrote:
> 
>> Mark,
>> Since you fixed push notifications, fully charged notification works for the Tazzari. Charge interrupt notification doesn't.
>> 
>> Regards,
>> Patrick
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev at lists.teslaclub.hk
>> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
> 
> _______________________________________________
> OvmsDev mailing list
> OvmsDev at lists.teslaclub.hk
> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20130414/3d18bc91/attachment.htm>