No problem, I removed the project file changes and updated the pull request.

I did at least try to make sure it would merge cleanly by manually editing it, but I know Xcode doesn't always play nice even then :)

--Bill

On Nov 18, 2022, at 02:34, Mark Webb-Johnson <mark@webb-johnson.net> wrote:

I can have a look at it.

The issue I’ve had with these in the past is that the patches to project files don’t go in cleanly. Usually easier to just include the standardised image files and I then need to handle the project code to include them.

Mark

On 18 Nov 2022, at 12:29 PM, William Reading <fbu6@anmt.net> wrote:

I've got a pull request out for the 500e images over at the iOS repository: https://github.com/openvehicles/Open-Vehicle-iOS/pull/52

(more or less the same as https://github.com/openvehicles/Open-Vehicle-Android/pull/143, but with a tweak to make the map image be a square like the other things in iOS)

Would anyone mind taking a look?

Thanks,
William Reading

On Feb 22, 2022, at 19:23, William Reading <fbu6@anmt.net> wrote:

Howdy there,

I recently got an OVMS set up with my Fiat 500e and was happy to see that it works, but I noticed noticed a few oddities.

The first one is that it uses Valet Mode (CommandActivateValet) for preconditioning instead of CommandClimateControl:
https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/bd192f5c1bf7ea77d94bf6e504cefa55f6365f5c/vehicle/OVMS.V3/components/vehicle_fiat500/src/vehicle_fiat500e.cpp#L550-L577

Is there a downside to changing the code to where it uses Climate Control instead? It seems like that would fit better with the intended functionality.

The other is that it seems to rapidly generate spurious charging / not charging events, which en masse seems to make the websocket connection on the web server time out.

I can put together a pull request to try to fix these issues, but was wondering if there are any thoughts on these two things before getting started. There's also no pictures of the Fiat on the iOS App, but I assume that's because the last release of the iOS App predates support.

Thanks,
William Reading

_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev

_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev