Håkon,

I've merged your latest changes in. Can you PULL, and check all is ok?

Regards, Mark.

On 14 Nov, 2013, at 4:39 pm, Håkon Markussen <hakon.markussen@gmail.com> wrote:

Testing of false 12V alerts was successfully. No false notifications has arrived from my Think City.

The conclusion is that car_doors1bits.CarON and car_doors5bits.Charging12V have to be correctly sett according to the 12V-battery charging state and car-state (in the vehicle-specific file).

No changes have to be made at net.c (car_12vline_ref -15).

Br.
Håkon


2013/11/13 Håkon Markussen <hakon.markussen@gmail.com>
I have now rolled back locally the net.c to «car_12vline_ref - 15» and added 
car_doors1bits.CarON = 0; 
car_doors5bits.Charging12V = 0;
to vehicle_thinkcity.c when:
- discharge is not allowed AND charge is not enabled

In addition to car_doors5bits.Charging12V = 1;  when:
 - charge is enabled
 - End of Charge is detected AND plug is attached

Some quick tests gives positive result that no 12V Critical Alert is send.
I’ll keep you posted.

Br.
Håkon

 
13. nov. 2013 kl. 08:51 skrev Håkon Markussen <hakon.markussen@gmail.com>:

False 12V alerts disappeared when triggering alert from ref - 2,0V.

    // Trigger 12V alert if voltage <= ref - 1.5 V:
    if (!(can_minSOCnotified & CAN_MINSOC_ALERT_12V)
            && (car_12vline <= (car_12vline_ref - 20)))
    {
      can_minSOCnotified |= CAN_MINSOC_ALERT_12V;
      net_req_notification(NET_
NOTIFY_12VLOW);
    }

Br.
Håkon



2013/11/12 Håkon Markussen <hakon.markussen@gmail.com>
When setting Notifications (parameter #3) to "IP" or "SMSIP" I finally receive alerts - including Minimum SOC (feature #9) ;)

The 12V Critical Alert triggers quite often, even if my 12V-battery is new and in top condition.
I've measured that the car_12vline reports ~0,5V less than the real battery voltage, so I plan to change the file net.c (line 1458) from:
 
   // Trigger 12V alert if voltage <= ref - 1.5 V:
    if (!(can_minSOCnotified & CAN_MINSOC_ALERT_12V)
            && (car_12vline <= (car_12vline_ref - 15)))
    {
      can_minSOCnotified |= CAN_MINSOC_ALERT_12V;
      net_req_notification(NET_NOTIFY_12VLOW);
    }

to:

    // Trigger 12V alert if voltage <= ref - 1.5 V:
    if (!(can_minSOCnotified & CAN_MINSOC_ALERT_12V)
            && (car_12vline <= (car_12vline_ref - 20)))
    {
      can_minSOCnotified |= CAN_MINSOC_ALERT_12V;
      net_req_notification(NET_NOTIFY_12VLOW);
    }

and compile it to a local hex-build and test in on my Think City.
Keep you posted about the result.

Best regards.
Håkon


2013/10/30 Mark Webb-Johnson <mark@webb-johnson.net>

Can someone try it at 2.0V (rather than 1.5V) and see if it solves the false-alerts problem?

Regards, Mark.

On 29 Oct, 2013, at 5:10 pm, Rolf Welde Skeie <rwskeie@gmail.com> wrote:

> Ok, it seems like a few have similar issues.
> The logic behind the calculations seems to be reasonable, it is the assumption that there is a 1.5V difference between charging/non-charging state which is not generally applicable.
> From my observations it seems like increasing this to 2.0V would take care of most mis-firing events.?..
>
> Disclaimer: I'm not an expert on batteries...
>
> Running on 2.5.5 experimental/TC
>
> Rolf
>
> On 10/29/2013 10:00 AM, Matt Beard OVMS wrote:
>> Yup, I also get this message and it would be great if it were working
>> properly, but it actually fires at 13.1V which is far too high.
>>
>> Matt
>>
>>
>>
>> On 29 October 2013 08:46, Rolf Welde Skeie <rwskeie@gmail.com
>> <mailto:rwskeie@gmail.com>> wrote:
>>
>>    I have the following features set:
>>    #0=1, #8=1, #9=1, #15=1, all others =0.
>>
>>    Can't remember which one made it work, but one of them did, my guess
>>    would be #9 :)
>>
>>    Rolf
>>
>>
>>    On 10/29/2013 09:38 AM, Håkon Markussen wrote:
>>
>>        I never get this alert.
>>        I have a Think City (as Rolf Skeie) and use the iOS-app.
>>        I have tested on both an exhausted aux-battery and on a brand new
>>        battery in perfect condition.
>>
>>        Br.
>>        Håkon
>>
>>
>>        2013/10/29 Thomas Bergo <thomas.bergo@gmail.com
>>        <mailto:thomas.bergo@gmail.com>
>>        <mailto:thomas.bergo@gmail.com <mailto:thomas.bergo@gmail.com>__>>
>>
>>
>>             I'm also get this alert.
>>
>>             Regard, Thomas
>>
>>             tirsdag 29. oktober 2013 skrev Rolf Welde Skeie følgende:
>>
>>                 Hi,
>>
>>                 I'm getting 12V battery alerts ala:
>>                 "MP-0 PAALERT!!! 12V BATTERY CRITICAL (13.2V, ref=14.7V)"
>>
>>                 So the 1.5V hardcoded difference between charged and
>>        non-charged
>>                 state seems to be too low. The battery is working just
>>        fine and
>>                 has been tested without any issues, but seems to
>>        stabilize at
>>                 approx. 12.8V.
>>
>>                 Is this a global issue; are others experiencing this as
>>        well?
>>
>>                 If this is a issue only relevant to my car: would it
>>        make sense
>>                 to allow for controlling some of these kind of values
>>        through
>>                 parameters?
>>
>>                 BTW, I believe the Think City module could be put in the
>>                 production builds, it seems to be working fine.
>>
>>                 Best regards
>>                 --
>>                 Rolf Welde Skeie
>>                 Solåsen 27, 5223 Nesttun, Norway
>>        +47 92403016 <tel:%2B47%2092403016> <tel:%2B47%2092403016> /
>>        rwskeie@gmail.com <mailto:rwskeie@gmail.com>
>>                 ___________________________________________________
>>                 OvmsDev mailing list
>>        OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk>
>>        http://lists.teslaclub.hk/____mailman/listinfo/ovmsdev
>>        <http://lists.teslaclub.hk/__mailman/listinfo/ovmsdev>
>>
>>                 <http://lists.teslaclub.hk/__mailman/listinfo/ovmsdev
>>        <http://lists.teslaclub.hk/mailman/listinfo/ovmsdev>>
>>
>>
>>             _________________________________________________
>>             OvmsDev mailing list
>>        OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk>
>>        <mailto:OvmsDev@lists.__teslaclub.hk
>>        <mailto:OvmsDev@lists.teslaclub.hk>>
>>
>>        http://lists.teslaclub.hk/__mailman/listinfo/ovmsdev
>>        <http://lists.teslaclub.hk/mailman/listinfo/ovmsdev>
>>
>>
>>
>>
>>        _________________________________________________
>>        OvmsDev mailing list
>>        OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk>
>>        http://lists.teslaclub.hk/__mailman/listinfo/ovmsdev
>>        <http://lists.teslaclub.hk/mailman/listinfo/ovmsdev>
>>
>>
>>    --
>>    Rolf Welde Skeie
>>    Solåsen 27, 5223 Nesttun, Norway
>>    +47 92403016 <tel:%2B47%2092403016> / rwskeie@gmail.com
>>    <mailto:rwskeie@gmail.com>
>>    _________________________________________________
>>    OvmsDev mailing list
>>    OvmsDev@lists.teslaclub.hk <mailto:OvmsDev@lists.teslaclub.hk>
>>    http://lists.teslaclub.hk/__mailman/listinfo/ovmsdev
>>    <http://lists.teslaclub.hk/mailman/listinfo/ovmsdev>
>>
>>
>>
>>
>> _______________________________________________
>> OvmsDev mailing list
>> OvmsDev@lists.teslaclub.hk
>> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
>>
>
> --
> Rolf Welde Skeie
> Solåsen 27, 5223 Nesttun, Norway
> +47 92403016 / rwskeie@gmail.com
> _______________________________________________
> OvmsDev mailing list
> OvmsDev@lists.teslaclub.hk
> http://lists.teslaclub.hk/mailman/listinfo/ovmsdev

_______________________________________________
OvmsDev mailing list
OvmsDev@lists.teslaclub.hk
http://lists.teslaclub.hk/mailman/listinfo/ovmsdev




_______________________________________________
OvmsDev mailing list
OvmsDev@lists.teslaclub.hk
http://lists.teslaclub.hk/mailman/listinfo/ovmsdev