I also sent another pull request for a minimal implementation of the charger state related values in the v2 protocol, and some small leaf fixes.
This pull request ( https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/7 ) is still outstanding
I think deriving the car_chargestate string from the charge flags is not correct. We've currently got…
OvmsMetricString* ms_v_charge_state; // charging, topoff, done, preparing, heating, stopped
OvmsMetricString* ms_v_charge_mode; // standard, range, performance, storage
OvmsMetricString* ms_v_charge_substate; // tba...
…but no longer their numerical equivalences as metrics -- assuming they are no longer necessary. Are they? I.e. do we need the numerical values other than for
the old V2 protocol?
I'd else translate the old codes to their old numerical values just for the "S" msg.