Michael,

It depends on whether the poller can *only* be used in the vehicle class or if it is a framework all by itself (for example with commands to manually poll specific PIDs, etc).

If *only* within vehicle framework, then putting it as a sub-command under ‘vehicle’ seems sensible.

If more general purpose, then perhaps look at ‘copen’ (component/canopen) as an example.

Regards, Mark.

On 10 Mar 2024, at 7:25 AM, Michael Geddes <frog@bunyip.wheelycreek.net> wrote:

Hi all,

I know some of this (especially for the status) functionality is predicated on code that's not gone up yet - however this is allowing 'pause' and 'resume' of the poller (which has been merged).
My question is not so much about the functionality and status information, but about the location of the poller subcommand. (See below). 

Should 'vehicle' be exclusively for switching the vehicle type?  Should the 'poller' command be top-level?  Under obdii?  

Thoughts welcome.
If you do  vehicle poller pause  then the last line reads  'Vehicle OBD Polling is paused'
//.
-------8<----------------------------------------

OVMS# vehicle ?
Usage: vehicle [list|module|poller|status]
list                 Show list of available vehicle modules
module               Set (or clear) vehicle module
poller               OBD polling status
status               Show vehicle module status
OVMS# vehicle poller ?
Usage: vehicle poller [pause|resume]
pause                Pause OBD Polling
resume               Resume OBD Polling
OVMS# vehicle poller
OBD Polling running on bus 1 with an active list
Time between polling ticks is 1000ms with 1 secondary sub-ticks
Last poll command received 1s (ticks) ago.
Vehicle OBD Polling is running.
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev