Chris & everyone,

I've pushed my fix for the out of sequence transmissions and faulty transmission logs on bulk transmissions. My tests showed the esp32can driver had the same issue.

The fix uses a mutex to avoid concurrent frame writes from the application and CAN task context.

In addition I fixed a bug in the mcp2515 driver that caused endless log spam in case of bus errors -- the same error condition would get logged over and over again.

Chris, I've also raised the default CAN TX queue size to 30 to allow your 22 frames to be queued with a standard build as well. But I hope that's just a first hack and won't be necessary once you figured out how the protocol works.

Regards,
Michael


Am 19.09.20 um 13:13 schrieb Chris van der Meijden:
Perfect! Thanx.

I'm back on track on monday.

Regards

Chris

Am Samstag, den 19.09.2020, 13:12 +0200 schrieb Michael Balzer:
Chris,

I've now set up a test environment for CAN2 & 3 and have begun investigating the issue.

I'll come back to you when I've fixed it.

Regards,
Michael


Am 18.09.20 um 19:51 schrieb Michael Balzer:
Chris,

the fix isn't meant to eliminate bus errors, it just should solve the log errors.

I.e. you should now see exactly those frames in the TX log, that you transmit.

TX_Fail log entries can result from actual bus errors as well as from TX queue overflows.

TX queue overflows are counted separately, see can can3 status. If you have TX overflows, you need to raise the queue size.

Regards,
Michael


Am 18.09.20 um 19:38 schrieb Chris van der Meijden:
I did a first test with mixed results.

I don't see the Asynchronous Errors anymore, but I see TX_FAIL messages and neither unlocking nor climate control works with the patch.

I will continue on monday with some deeper checks and I hope I can produce some
log output then.

Regards

Chris


_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev



_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev


-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev


_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev


-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26