Running smoothly on my bench module.

Your refactorization changes also look good to me. (Side note: I'd opt for generally keeping trailing white space. I use them for graphical purposes and to denote continuing paragraphs in text files (rst), which my editor automatically does to provide consistent rewrapping.)

I suggest renaming the command root "modem" to something not breaking the "mo" or "mod" shortcut for "module". I generally try to make/keep command abbreviations work at 2-3 characters.

As "modem" is also a general device class (also applicable to the wifi modem), how about calling it "cellular" instead?

That would also allow to add some general cellular network specific commands without breaking semantics.

Regards,
Michael


Am 30.08.20 um 09:20 schrieb Mark Webb-Johnson:

The initial implementation of this work is in branch for-v3.3, in GitHub. That branch can be used for the upcoming 3.3 release, including potentially breaking changes.

I’d appreciate any feedback. For the SIM5360, the behaviour should be unchanged from the current implementation (except some improvements to edge cases and control logic). The major user visible change is from ’simcom’ to ‘modem’ for the console commands.

Regards, Mark.

On 20 Aug 2020, at 9:35 PM, Mark Webb-Johnson <mark@webb-johnson.net> wrote:


I have started the work on refactoring the modem driver to support virtual driver implementations (SIMCOM 5360 being just one of them). This is a major refactoring that will take some time to complete. It is likely that the following components/files will be affected:

  • Component simcom (major changes)
  • New component ovms_modem introduced
  • ovms_webserver/dev/commands.htm
  • ovms_webserver/src/web_cfg_init.cpp
  • ovms_webserver/src/web_cfg.cpp
  • Component powermgmt
  • And several other components mentioning Simcom, but only very minor changes

I would appreciate it if no major changes were made to those components in the next week or two, as that may make merging difficult.

Once I’ve got the modem code refactored, and a compatible SIMCOM 5360 driver working, I’ll publish to the for-v3.3 branch for wider testing. I can then add the other modem drivers I have been working on.

Regards, Mark.

P.S. Pretty obvious that this work is to abstract out the modem type specific code, to make it easier to add support for other modem types in OVMS. This is a long-term project, and not something happening anytime soon, but I am working on it.

_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev


_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev


-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26