Adding the separate sub-commands would be easy enough to add to this to force only temp or only volt. I had

contemplated it and it would be very easy given what I've already done.

I think from your screenshot, you would be ok with 4 + 1 cols too in that narrow arrangement.. so maybe I should just limit the display to 5 cols overall ?

imho I think that would be a lot better than what happens now with readings per module > 4!

Your Six modules would split into 2 lines of 3 in the current code.. would that be a problem?

For the ioniq 5, the info from the csv for torquepro shows a possible 192 cells, and it describes the temperatures as belonging to 'battery pack 1' through to 'battery pack 16', so I'm inclined to think that they have a temperature sensor there for pack 16? even though it would be empty in my car (180 cells filled).

//.ichael

On Tue, 1 Nov 2022 at 16:50, Michael Balzer <dexter@expeedo.de> wrote:

Michael,

regarding separate temperature / voltage display, I suggest adding sub commands, i.e. "bms temp" / "bms volt".

Regarding the layout: it's difficult to tell what will fit, especially in vertical orientation, as this depends on the display and font size chosen. With a font size of 12.0 on my Huawei, max 4 columns would fit:

https://drive.google.com/file/d/1ra6QWcPh03rd5GO9xyykY3ZI_ofRrzj1/view?usp=share_link
https://drive.google.com/file/d/1rasYOBL8lY1NwM9oq_gL6pvcX-uinJjj/view?usp=share_link

Regarding your temperature sensors: it's possible you've actually got <modules>+1 sensors if they are placed between the modules. You should see that when heating up the battery by driving, an empty/reserved module space wouldn't heat up as much as filled modules. For a layout of temperature sensors between the cell modules, you could decide to derive the module temperature by building the average of it's adjacent sensors.

Regards,
Michael

Am 01.11.22 um 09:19 schrieb Michael Geddes:
Is there any reason I shouldn't create a pull request for this?

At the moment a multiple of 5 (but not a multiple of 4) will give you 5 columns ..

though I suspect this won't output nicely on the mobile app 'Messages' which really will probably only work nicely with 4+1=5 total columns.

This is my latest output

with

Voltage

Cells = 180 (of 192 max)

Readings Per Module = 12 (so 15 modules of a possible 16)

Temperature

Readings = 16

Readings Per Module = 1

OVMS# bms
Voltage:
Average: 3.636V [3.620V - 3.640V]
Deviation: SD 7.98mV [max 0.00mV], 0 warnings, 0 alerts
Temperature:
Average: 17.2C [ 17.0C - 18.0C]
Deviation: SD 0.39C [max 0.39C], 0 warnings, 0 alerts
Cells:
+-----------------------------+--------+
1 | 3.640V 3.640V 3.640V 3.640V | 18.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
2 | 3.620V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
3 | 3.640V 3.640V 3.640V 3.640V | 18.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
4 | 3.620V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.620V 3.640V | |
+-----------------------------+--------+
5 | 3.620V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
6 | 3.640V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
7 | 3.640V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.620V 3.620V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
8 | 3.620V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.620V 3.620V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
9 | 3.640V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.640V 3.620V 3.620V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
10 | 3.640V 3.640V 3.640V 3.640V | 17.0C |
| 3.620V 3.620V 3.620V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
11 | 3.620V 3.640V 3.640V 3.640V | 17.0C |
| 3.620V 3.640V 3.640V 3.640V | |
| 3.620V 3.640V 3.620V 3.620V | |
+-----------------------------+--------+
12 | 3.620V 3.640V 3.620V 3.620V | 17.0C |
| 3.640V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.620V | |
+-----------------------------+--------+
13 | 3.620V 3.620V 3.640V 3.640V | 17.0C |
| 3.620V 3.640V 3.640V 3.620V | |
| 3.640V 3.620V 3.640V 3.620V | |
+-----------------------------+--------+
14 | 3.620V 3.640V 3.640V 3.640V | 17.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.620V 3.640V 3.620V | |
+-----------------------------+--------+
15 | 3.620V 3.640V 3.640V 3.640V | 18.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.620V | |
+-----------------------------+--------+
16 | | 17.0C |
+-----------------------------+--------+

On Tue, 1 Nov 2022 at 07:29, Michael Geddes <frog@bunyip.wheelycreek.net> wrote:

.. As to whether this is correct for my i5: it might actually be correct.

My i5 seems to have 180 of a possible 192 cells. It seems that it's likely there are 12 cell packs in a module (https://insideevs.com/news/539940/hyundai-ioniq5-battery-pack-opened/)

Which possibly means they still have a temperature sensor for the unfilled module!? Which would make this correct!

I wonder if I should cap the temperature sensors based on the number of battery packs?

Anyway.

Should I try and reduce the height of that last module entry?

//.ichael

On Tue, 1 Nov 2022 at 07:19, Michael Geddes <frog@bunyip.wheelycreek.net> wrote:

Hi all,

I'll create a PR soon, but just wanted to ask something first.

I've made the 'bms' command so that it will work with temperature OR voltages and only display that one column. For example:

OVMS# bms
Temperature:
Average: 3.6C [ 3.6C - 3.6C]
Deviation: SD 0.00C [max 0.48C], 0 warnings, 0 alerts
Cells:
+--------+
1 | 14.0C |
+--------+
2 | 14.0C |
+--------+
3 | 14.0C |
+--------+
4 | 15.0C |
+--------+
5 | 14.0C |
+--------+
6 | 3.6C |
+--------+
7 | 3.6C |
+--------+
8 | 3.6C |
+--------+
9 | 3.6C |
+--------+
10 | 3.6C |
+--------+
11 | 3.6C |
+--------+
12 | 3.6C |
+--------+
13 | 3.6C |
+--------+
14 | 3.6C |
+--------+
15 | 3.6C |
+--------+
16 | 3.6C |
+--------+

The other improvement I'm trying, and want some feedback on is when you have readings-per-module set > 4. Here I don't have it set quite right.. but you get the idea. The setting is at 12, which ends up being quite wide (yes, there's one temperature sensor off on its own, so my setting is not quite right yet).

At the moment the column count is capped at 4 (and will cope with it not dividing properly), but the idea would be something along the lines of trying n % 3 and n % 5 first and then 4. So cap the column count at 3, 5 or 4 depending. The idea is that this becomes readable in the APP!

Thoughts?

OVMS# bms
Voltage:
Average: 3.632V [3.620V - 3.640V]
Deviation: SD 9.75mV [max 0.00mV], 0 warnings, 0 alerts
Temperature:
Average: 14.0C [ 13.0C - 15.0C]
Deviation: SD 0.35C [max 0.48C], 0 warnings, 0 alerts
Cells:
+-----------------------------+--------+
1 | 3.640V 3.640V 3.640V 3.640V | 14.0C |
| 3.640V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.620V | |
+-----------------------------+--------+
2 | 3.620V 3.620V 3.640V 3.640V | 14.0C |
| 3.620V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.620V | |
+-----------------------------+--------+
3 | 3.620V 3.640V 3.640V 3.640V | 14.0C |
| 3.640V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.620V | |
+-----------------------------+--------+
4 | 3.620V 3.640V 3.640V 3.640V | 14.0C |
| 3.640V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.620V 3.620V | |
+-----------------------------+--------+
5 | 3.620V 3.620V 3.640V 3.640V | 14.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.620V 3.620V | |
+-----------------------------+--------+
6 | 3.640V 3.640V 3.640V 3.640V | 15.0C |
| 3.640V 3.620V 3.620V 3.640V | |
| 3.640V 3.620V 3.620V 3.620V | |
+-----------------------------+--------+
7 | 3.640V 3.640V 3.640V 3.640V | 13.0C |
| 3.620V 3.620V 3.620V 3.620V | |
| 3.640V 3.640V 3.620V 3.620V | |
+-----------------------------+--------+
8 | 3.620V 3.640V 3.620V 3.640V | 14.0C |
| 3.640V 3.620V 3.620V 3.620V | |
| 3.640V 3.640V 3.620V 3.620V | |
+-----------------------------+--------+
9 | 3.640V 3.640V 3.640V 3.640V | 14.0C |
| 3.620V 3.620V 3.620V 3.620V | |
| 3.640V 3.620V 3.640V 3.640V | |
+-----------------------------+--------+
10 | 3.620V 3.640V 3.640V 3.620V | 14.0C |
| 3.640V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
11 | 3.620V 3.640V 3.640V 3.640V | 14.0C |
| 3.640V 3.620V 3.640V 3.640V | |
| 3.620V 3.620V 3.640V 3.620V | |
+-----------------------------+--------+
12 | 3.620V 3.620V 3.620V 3.620V | 14.0C |
| 3.620V 3.620V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.620V | |
+-----------------------------+--------+
13 | 3.620V 3.620V 3.640V 3.640V | 14.0C |
| 3.640V 3.620V 3.620V 3.640V | |
| 3.640V 3.640V 3.640V 3.620V | |
+-----------------------------+--------+
14 | 3.620V 3.620V 3.640V 3.640V | 14.0C |
| 3.620V 3.620V 3.620V 3.620V | |
| 3.620V 3.620V 3.640V 3.620V | |
+-----------------------------+--------+
15 | 3.620V 3.640V 3.640V 3.640V | 14.0C |
| 3.640V 3.640V 3.640V 3.640V | |
| 3.640V 3.640V 3.640V 3.640V | |
+-----------------------------+--------+
16 | | 14.0C |
| | |
| | |
+-----------------------------+--------+
OVMS#
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev
-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev