Yep, please steer clear of the car_chargermode variable. That is really badly named and is more an operation mode (like Eco/Normal on a Prius, for example). I think it is named as it is because the source on the roadster is the charger message.
I suggest:
unsigned char car_chargeplug;
and setup an enumeration as desired. Create it in ovms.{h,c} and then add it on the end of the ’S’ message.
If someone wants to commit that and send in a pull request, I’ll accept (and update the protocol guide myself).
Regards, Mark.
On 9 Dec 2015, at 3:10 AM, Robert Cotran <robert@cotran.ca> wrote:I like the idea of having charge type for logging purposes._______________________________________________
I agree it shouldn't be combined with the Roadster charging types.
Can just create a new "field" called connector type?
On 12/8/2015 2:07 PM, Nikki Gordon-Bloomfield wrote:
Charge type would become important if you were automatically sending charge session data back (anonymously) to the OCM database…ᐧ
On Tue, Dec 8, 2015 at 10:46 AM, Tom Saxton <tom@idleloop.com> wrote:
The chargemode currently encodes software charging profiles, based on what the Roadster offers. It's similar to what the early Leafs offered, charging to full or charge to 80%, but more complex setting both a charging limit and target battery temperature ranges.
What you are proposing adding is to encode the charging connection type, which is a different kind of thing, orthogonal to the car's chosen charging profile.
A Roadster can charge in any of the four profiles from either a Level 1 connection (120V, 12A to 16A) or Level 2 (208V to 240V at up to 70A), for example Standard mode on Level 1 or Range mode on Level 2. So, you can't encode both a charging profile and a connection type with a single number. A Leaf is similar in how those two interact.
To me, the interesting thing is more the charge rate (V/A or kW) more than which connector my car uses. I don't need OVMS to tell me how I plugged in, but I do care about knowing how fast it's charging.
Tom
On 12/8/15, 10:19 AM, "Geir Øyvind Vælidalo" <ovmsdev-bounces@lists.teslaclub.hk on behalf of geir@validalo.net> wrote:
>Hi guys,
>
>I would like to have ChaDeMo and CSS added to car_chargemode, and maybe Type 1 and Type 2 too. Then we can display those names in the apps and maybe even add images for those charge plugs.
>I would propose this:
>0x00 - Standard
>0x01 - Storage
>0x02 - ???
>0x03 - Range
>0x04 - Performance
>0x05 - ChaDeMo
>0x06 - CSS
>0x07 - J1772 Type 1
>0x08 - Mennekes Type 2
>
>What to you guys think? Would it be problematic for the server and/or apps if suddenly the Kia Souls stated sending chargemode 0x05?
>
>Best regards,
>Geir
>
>_______________________________________________
>OvmsDev mailing list
>OvmsDev@lists.teslaclub.hk
>http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
>
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.teslaclub.hk
http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
_______________________________________________ OvmsDev mailing list OvmsDev@lists.teslaclub.hk http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
OvmsDev mailing list
OvmsDev@lists.teslaclub.hk
http://lists.teslaclub.hk/mailman/listinfo/ovmsdev
