We can also add the "sufficient SOC/range reached" notifications, the low SOC alert and the low 12V alert to the framework.

Porting the low 12V detection is on my list for today/tomorrow. For the sufficient SOC/range notifications, I currently still (mis-)use the topoff state, which is irritating to users.

Notification config should include a channel selection for each, so users can choose which of them to get by SMS. May be combinable, i.e. instead of a bool, use a set of ("ip", "sms")?

Regards,
Michael


Am 25.04.2018 um 03:13 schrieb Mark Webb-Johnson:
It is time to implement vehicle notifications (charge started, charge completed, charge interrupted, etc) in the vehicle modules I am supporting. It seems that this can be done in the vehicle.{h,cpp} framework in a standard manner, and work across all vehicle types. However, I guess that will break any notifications already being produced by other vehicle types.

My suggestion is:

  1. A config parameter ‘notifications’, with individual instances to turn on/off the notifications. Default is all enabled.

  2. OvmsVehicle::MetricModified picks up metric changes and issues the standard notifications (checking ‘notifications’ parameter appropriately).
    • charge_mode=>charging: Notify charge started
    • charge_mode=>topoff: Notify charge started
    • charge_mode=>heating: Notify battery heating started
    • charge_mode=>done: Notify charge completed
    • charge_mode=>stopped: Notify charge interrupted
    • valet_mode=>on: Notify valet mode enabled
    • valet_mode=>off: Notify valet mode disabled
    • alarm=>on: Notify alarm is sounding
    • alarm=>off: Notify alarm is off

  3. All the above should be suppressed for the initial setting of each parameter. I will have to look into metrics to see how best that should be done; one neat way is to keep a modification count (rather than the current m_defined boolean).

Does that make sense? Any objections/suggestions?

Regards, Mark



_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev

-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26