Solterra,

Michael’s advice is good.

If it is just two names for essentially the same vehicle, I think you can refer to vehicle_voltampera (which implemented the Chevy Volt and Open Ampera vehicle support). These were essentially the same vehicle platform, but with minor bodywork differences and labelling.

If the two vehicles share the same platform (such as BMS, battery, etc) but are otherwise very different, then I suggest you implement a vehicle_<platform> for that platform, and derive two classes from that in the same /src/ directory (one for each vehicle type). That will allow you to put all common support code in the base platform, but have each vehicle type customisable (and individually selectable).

Looking at images of the cars, it seems they are closest to the Volt Ampera situation. Perhaps BZSS?

Regards, Mark.

On 28 May 2023, at 8:23 AM, Michael Geddes <frog@bunyip.wheelycreek.net> wrote:

Hey Solterra, 
I couldn't say definitively but imho there are various options depending on HOW different.

1) They are exactly the same - or differences can be distinguished from responses: Register the name with both in it. Done. (This has happened with some older Kia + Hyundai even)
2)  They are mostly the same.  You could probably keep the one directory but have  2 wrapper classes constructing the base class with a parameter and register both in the factory Init. (Not sure if there are examples - ask the other Michael if this is ok).
3) They have a lot of commonality.  You can inherit off a base class - or inherit one vehicle impl off the other... But put them in separate directories.  (This happens for Ioniq 5 and a bunch of other Kia + Hyundai cars).

//.ichael Geddes

On Sat, 27 May 2023 at 21:19, Solterra <solterra@kezarnet.com> wrote:

Hello again,

I've finished my initial vehicle investigation and am not ready to add support to OVMS.

When creating the vehicle stub, is there guidance for situations like on this vehicle? There are two makes and models that are essentially the same. Can I create a common 'components/vehicle_toyota_bz4x' and point two vehicle selections to it somewhere else?

Thank you


_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.openvehicles.com
http://lists.openvehicles.com/mailman/listinfo/ovmsdev