Hi Michael,

Thanks for the review and the background on the otherwise useless call. I'll make the changes and push.

Sorry about the '\n'. Muscle memory from too many years of printfs... The indentation style thing, actually, I was trying to match what was done in the original code. Kind of bugged me too, but I didn't want to upset things too much.

Thanks again,

Greg

Michael Balzer wrote:

Greg,

looks correct, just some general notes:

Line 252: "so why are we even here?" -- because the RxCallback() will be called again after fetching an RX buffer to check for the other RX buffer. If no other RX and no error occurred, the callback loop can be terminated. It may also be that the RxCallback() loop fetches an RX that occurred after the trigger of the current loop, so the framework will call again after polling the intermediate RxCallback request, but the buffer will already be empty.

Line 294: this should be a warning level log, also the "\n" at the end isn't necessary for a log.

Code style: for readability and maintainability, please try to adopt the general coding style (at least indentation & line break / space conventions) of the module you're changing, or run a formatter on your changes before committing.

Regards,
Michael

Am 11.01.2018 um 05:55 schrieb Greg D.:

For receive, I'd go with what I have for now, if Michael would be so kind as to review what I have done first. https://github.com/bitsofgreg/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/mcp2515/mcp2515.cpp Hopefully he'll be back on line before I get up in the morning. Wonderful how the Earth's spin helps with the teamwork.
-- 
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26
_______________________________________________
OvmsDev mailing list
OvmsDev@lists.teslaclub.hk
http://lists.teslaclub.hk/mailman/listinfo/ovmsdev