<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Chris,<br>
<br>
<div class="moz-cite-prefix">Am 04.02.25 um 23:49 schrieb Chris Box:<br>
</div>
<blockquote type="cite"
cite="mid:010b0194d32793c1-1ef3e288-04d2-4277-bd62-22dfa1da60a1-000000@eu-west-2.amazonses.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<blockquote type="cite"
style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">
<div id="replybody1">
<div class="v1moz-cite-prefix">Am 15.01.25 um 11:11 schrieb
Michael Balzer via OvmsDev:</div>
<blockquote type="cite"
style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">Speaking
of the Leaf, the code there actually does something fishy in
`CommandWakeup()`:<br>
<br>
<span style="font-family: monospace;"> unsigned char data =
0;<br>
...<br>
m_can1->WriteStandard(0x5C0, <strong><u>8</u></strong>,
&data); //Wakes up the VCM (by spoofing empty battery
request heating)</span></blockquote>
</div>
</blockquote>
<div> </div>
<div>I agree that is dodgy. It's going to write 8 bytes of data
onto the bus, but only the first byte's contents are known. The
other 7 are nondeterministic - just whatever happened to be on
the stack at that time. This doesn't seem like a recipe for
predictable operation.</div>
</blockquote>
<br>
I'd say that seems like a recipe for an occasional car fault
condition. If the message needs to be 8 bytes long, I'd expect the
car to normally also process all 8 bytes.<br>
<br>
<blockquote type="cite"
cite="mid:010b0194d32793c1-1ef3e288-04d2-4277-bd62-22dfa1da60a1-000000@eu-west-2.amazonses.com">
<div>The commit was <a
href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commit/09c58a2feda13c32f79c6599fdcb6a7512cf1a48"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commit/09c58a2feda13c32f79c6599fdcb6a7512cf1a48</a>
by dalathegreat.</div>
<div> </div>
<div>Unfortunately my CAN knowledge is close to zero so I can't
comment on the messages themselves.</div>
</blockquote>
<br>
You could try if the 8 is the error here by replacing that by 1, and
if that then no longer works, you could try making data a
deterministic 8 null bytes frame.<br>
<br>
Regards,<br>
Michael<br>
<br>
<pre class="moz-signature" cols="72">--
Michael Balzer * Am Rahmen 5 * D-58313 Herdecke
Fon 02330 9104094 * Handy 0176 20698926</pre>
</body>
</html>