<div dir="ltr"><div>Hi Michael, Greg</div><div><br></div><div>Fyi, it looks like my messages also stopped on the 8 Jan GMT, I'm on Android 12 OVMS app version 4.1.2.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 26 Jan 2024 at 14:35, <<a href="mailto:ovmsdev-request@lists.openvehicles.com">ovmsdev-request@lists.openvehicles.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Send OvmsDev mailing list submissions to<br>
<a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" rel="noreferrer" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:ovmsdev-request@lists.openvehicles.com" target="_blank">ovmsdev-request@lists.openvehicles.com</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:ovmsdev-owner@lists.openvehicles.com" target="_blank">ovmsdev-owner@lists.openvehicles.com</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of OvmsDev digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: Messages stopped being received on phone (Michael Balzer)<br>
2. Re: Working on ESP-IDF5 + Have a question about ovms_module<br>
'Name' (Michael Geddes)<br>
3. Re: Working on ESP-IDF5 + Have a question about ovms_module<br>
'Name' (Mark Webb-Johnson)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Thu, 25 Jan 2024 19:55:40 +0100<br>
From: Michael Balzer <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a>><br>
To: <a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a><br>
Subject: Re: [Ovmsdev] Messages stopped being received on phone<br>
Message-ID: <<a href="mailto:93610d48-1492-4ca8-b3ff-1adee6c75ee0@expeedo.de" target="_blank">93610d48-1492-4ca8-b3ff-1adee6c75ee0@expeedo.de</a>><br>
Content-Type: text/plain; charset="utf-8"; Format="flowed"<br>
<br>
Greg,<br>
<br>
8th of January matches our preparation steps for the Firebase messaging <br>
migration.<br>
<br>
But that to my knowledge didn't involve any change to the server yet, <br>
and should only have added the Firebase instance to the Google cloud <br>
account without disabling the old GCM.<br>
<br>
Also? if it was an issue of the server / Google cloud, there certainly <br>
would be other users affected.<br>
<br>
I assume you didn't install the beta test App build yet? That could be <br>
worth a try. The new build works with both the old & new server API. <br>
Google wrote the old Android APIs would continue to work until June, but <br>
maybe that was too optimistic?<br>
<br>
Regards,<br>
Michael<br>
<br>
<br>
Am 25.01.24 um 00:22 schrieb Greg D.:<br>
> Hi folks,<br>
><br>
> I recently noticed that Alerts (Messages) have stopped coming to my <br>
> phone.? The last one was on 8-January '24.? The car is still operating <br>
> / charging normally, and has been driven since then. The Battery, Car, <br>
> and Location screens are up to date and live. The OVMS module is <br>
> connected to the home Wi-Fi, as normal, and I can access it through <br>
> the internal web server (dashboard, status, etc.).? But the phone <br>
> app's Messages page stops at 8-January.<br>
><br>
> I've not messed with the module in a long time.? Last boot, in fact, <br>
> was a crash back in July 2023, from which it recovered normally. (So <br>
> lovely seeing an uptime in excess of 17 million seconds.)<br>
><br>
> So, what happened back on 8-January?? The only thing I can think of <br>
> was that Android is being more aggressive about shutting down <br>
> background processing (in the name of increased battery life), but <br>
> leaving the app running in foreground and triggering an event still <br>
> wasn't seen on the phone.? I can see them on the Web's Dashboard, so <br>
> the events are being generated and processed otherwise normally.<br>
><br>
> The phone is a Pixel 7a, Android 14.? OVMS firmware is <br>
> 3.3.003/ota_1/eap (build idf v3.3.4-848-g1ff5e24b1 Sep 1 2022 08:40:30).<br>
><br>
> Any ideas?<br>
><br>
> Thanks,<br>
><br>
> Greg<br>
> _______________________________________________<br>
> OvmsDev mailing list<br>
> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" rel="noreferrer" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
<br>
-- <br>
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal<br>
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26<br>
<br>
-------------- next part --------------<br>
A non-text attachment was scrubbed...<br>
Name: OpenPGP_signature.asc<br>
Type: application/pgp-signature<br>
Size: 203 bytes<br>
Desc: OpenPGP digital signature<br>
URL: <<a href="http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20240125/7996b03f/attachment-0001.sig" rel="noreferrer" target="_blank">http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20240125/7996b03f/attachment-0001.sig</a>><br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Fri, 26 Jan 2024 09:23:42 +0800<br>
From: Michael Geddes <<a href="mailto:frog@bunyip.wheelycreek.net" target="_blank">frog@bunyip.wheelycreek.net</a>><br>
To: OVMS Developers <<a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a>><br>
Cc: "<a href="mailto:casner@acm.org" target="_blank">casner@acm.org</a>" <<a href="mailto:casner@acm.org" target="_blank">casner@acm.org</a>><br>
Subject: Re: [Ovmsdev] Working on ESP-IDF5 + Have a question about<br>
ovms_module 'Name'<br>
Message-ID:<br>
<<a href="mailto:CAH0p7u%2BKC5Nh1%2Bdds4ib3srAnVzMsNP3Lg7JVdrOF1YYpopy4w@mail.gmail.com" target="_blank">CAH0p7u+KC5Nh1+dds4ib3srAnVzMsNP3Lg7JVdrOF1YYpopy4w@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
Thanks Michael,<br>
I hadn't considered there would be an essay in the commit, thanks for that<br>
- though it doesn't shed a lot of light on the situation<br>
<br>
There seems to be 2 places that mark a Name using the high bit, and only<br>
one place that kinda-sorta reads it.<br>
<br>
The Name is 'marked' during populate() which seems to be to mark each name<br>
with a '*' and the high-bit, before going through and getting the current<br>
names for the processes - adding new ones and replacing the old ones<br>
without '*' and high-bit mark. So items which are double marked are<br>
effectively stale/historic.<br>
<br>
It is also 'marked' during the find call .. which basically marks the<br>
'found' name if it was not found and then constructed. The does not appear<br>
to be any purpose to this that I can ascertain.<br>
<br>
The one place (afaict) it reads the value is in zero() below - the problem<br>
is that it looks at the entire top uint32 rather than just that high<br>
byte!! It's hard to work out whether this is just a long-standing bug or<br>
whether it is weeding out names > 12 characters as well from being removed.<br>
So this seems to remove an item from the map, but only if it isn't marked<br>
(or long) ie if it isn't stale - or been 'seen' I guess?<br>
<br>
bool zero(TaskHandle_t taskid)<br>
{<br>
for (int i = 0; i < count; ++i)<br>
{<br>
if (map[i].id == taskid)<br>
{<br>
* if (map[i].name.words[NAMELEN/4-1] > 0)*<br>
return false;<br>
for (++i ; i < count; ++i)<br>
{<br>
map[i-1] = map[i];<br>
}<br>
--count;<br>
return true;<br>
}<br>
}<br>
return false;<br>
}<br>
<br>
Does this help? Any thoughts on what this was meant to do ? I've CCd<br>
Stephen with a hope he might chip in?<br>
<br>
//.<br>
<br>
<br>
On Wed, 24 Jan 2024 at 15:09, Michael Balzer <<a href="mailto:dexter@expeedo.de" target="_blank">dexter@expeedo.de</a>> wrote:<br>
<br>
> Michael,<br>
><br>
> Am 21.01.24 um 02:54 schrieb Michael Geddes:<br>
><br>
> Hey, In working trying to get ESP-IDF 5+ Working, I came across the<br>
> following fun thing that I'm trying to work out what is going on!!<br>
> This is from main/ovms_module.cpp<br>
> I'm not sure why we don't just go through all the words and compare - why<br>
> the masked compare for the last entry! And why that value?? It might make<br>
> sense if you masked out the final byte ... I'm just struggling to<br>
> understand.<br>
><br>
><br>
> From the further accesses to the last word/byte in TaskMap, I'd guess<br>
> Steve intended using the sign bit on the last byte as some special<br>
> indicator, but it's not clear to me for what purpose. It also doesn't seem<br>
> to be relevant anymore.<br>
><br>
> Steve's commit message is verbose<br>
> (30d0a403a380e797f9b222b01dab8da791ab388c), and maybe you can find some<br>
> more explanation in the list archives.<br>
><br>
> Regards,<br>
> Michael<br>
><br>
> Why am I looking at it?? Well there's a new warning about copy<br>
> constructors.. and then I ran into a problem where 'Name' is sometimes in<br>
> memory that can only be accessed 32bit int aligned (which is why the<br>
> strange implementation in the first place - I get that).<br>
><br>
> Can anybody shed any light on this?<br>
><br>
><br>
> class Name<br>
> {.......<br>
> inline bool operator==(const Name& a) const<br>
> {<br>
> for (int i = 0; i < NAMELEN/4 - 1; ++i)<br>
> if (a.words[i] != words[i]) return false;<br>
> i*f (a.words[NAMELEN/4-1] != (words[NAMELEN/4-1] & 0x7FFFFFFF))<br>
> return false;*<br>
> return true;<br>
> }<br>
><br>
> _______________________________________________<br>
> OvmsDev mailing listOvmsDev@lists.openvehicles.comhttp://<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" rel="noreferrer" target="_blank">lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
><br>
><br>
> --<br>
> Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal<br>
> Fon 02333 / 833 5735 * Handy 0176 / 206 989 26<br>
><br>
> _______________________________________________<br>
> OvmsDev mailing list<br>
> <a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
> <a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" rel="noreferrer" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
><br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20240126/5ca8f078/attachment-0001.htm" rel="noreferrer" target="_blank">http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20240126/5ca8f078/attachment-0001.htm</a>><br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Fri, 26 Jan 2024 09:34:09 +0800<br>
From: Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net" target="_blank">mark@webb-johnson.net</a>><br>
To: OVMS Developers <<a href="mailto:ovmsdev@lists.openvehicles.com" target="_blank">ovmsdev@lists.openvehicles.com</a>><br>
Subject: Re: [Ovmsdev] Working on ESP-IDF5 + Have a question about<br>
ovms_module 'Name'<br>
Message-ID: <<a href="mailto:E6A7C991-83E1-40E2-9CD1-19C827EA865F@webb-johnson.net" target="_blank">E6A7C991-83E1-40E2-9CD1-19C827EA865F@webb-johnson.net</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
Michael,<br>
<br>
Unfortunately, Steve passed away in 2022 so is unlikely to reply :-(<br>
<br>
He did work on some of the lower level and more complex parts of OVMS, as well as the command processing framework, and is sorely missed.<br>
<br>
I can?t help much with the code you are working on, other than to ask if this functionality is still required in the v5 IDF framework? A lot of stuff we did back then was to address inadequacies in the very new early buggy frameworks coming out of Espressif for the just released ESP-32.<br>
<br>
Regards, Mark.<br>
<br>
-------------- next part --------------<br>
An embedded message was scrubbed...<br>
From: Mark Webb-Johnson <<a href="mailto:mark@webb-johnson.net" target="_blank">mark@webb-johnson.net</a>><br>
Subject: Passing of Steve Casner<br>
Date: Fri, 8 Jul 2022 08:19:25 +0800<br>
Size: 507168<br>
URL: <<a href="http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20240126/251d3df8/attachment.eml" rel="noreferrer" target="_blank">http://lists.openvehicles.com/pipermail/ovmsdev/attachments/20240126/251d3df8/attachment.eml</a>><br>
-------------- next part --------------<br>
<br>
<br>
> On 26 Jan 2024, at 9:23 AM, Michael Geddes <<a href="mailto:frog@bunyip.wheelycreek.net" target="_blank">frog@bunyip.wheelycreek.net</a>> wrote:<br>
> <br>
> Does this help? Any thoughts on what this was meant to do ? I've CCd Stephen with a hope he might chip in?<br>
> <br>
> //.<br>
<br>
<br>
------------------------------<br>
<br>
Subject: Digest Footer<br>
<br>
_______________________________________________<br>
OvmsDev mailing list<br>
<a href="mailto:OvmsDev@lists.openvehicles.com" target="_blank">OvmsDev@lists.openvehicles.com</a><br>
<a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" rel="noreferrer" target="_blank">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br>
<br>
<br>
------------------------------<br>
<br>
End of OvmsDev Digest, Vol 144, Issue 8<br>
***************************************<br>
</blockquote></div></div>