<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /></head><body style='font-size: 10pt; font-family: Verdana,Geneva,sans-serif'>
<p>Thanks for the help. I ended up going with PollSingleRequest for the one-off messages (VIN request, Charge Type, and Charge Mode so far...). </p>
<p>It seems like sometimes it inturrupts a poll Tx/Rx cycle (receives the Rx from a previous poll and fails), so I added a retry in those instances. Code snip below. I'll probably encapsulate that (poll and retry) into a function to do a one-off requests. </p>
<p>I saw your post in March about changes to the OBD Poller (paying more attention now that I'm writing code...) Is that change still in the works? It sounds great.</p>
<p><br /></p>
<p>void OvmsVehicleToyotaETNGA::RequestChargeType()<br />{<br /> std::string response;<br /> int chargeType;<br /> int maxRetries = 5;<br /> int retryCount = 0;<br /> int res;</p>
<p> while (retryCount < maxRetries && res != POLLSINGLE_OK)<br /> {<br /> res = PollSingleRequest(<br /> m_can2,<br /> PLUG_IN_CONTROL_SYSTEM_TX,<br /> PLUG_IN_CONTROL_SYSTEM_RX,<br /> VEHICLE_POLL_TYPE_READDATA,<br /> PID_CHARGING_VOLTAGE_TYPE,<br /> response,<br /> 1000,<br /> ISOTP_STD<br /> );</p>
<p> if (res == POLLSINGLE_OK)<br /> {<br /> // Request successful<br /> chargeType = response[0] & 0xFF;<br /> SetChargeType(chargeType);<br /> break;<br /> }<br /> else<br /> {<br /> retryCount++;<br /> ESP_LOGW(TAG, "RequestChargeType: Request failed with error code %d. Retrying (%d/%d)", res, retryCount, maxRetries);<br /> }<br /> }</p>
<p> if (res != POLLSINGLE_OK)<br /> {<br /> ESP_LOGE(TAG, "RequestChargeType: Maximum retries reached. Request failed with error code %d", res);<br /> }<br />}</p>
<p><br /></p>
<div id="signature"></div>
<p><br /></p>
<p id="reply-intro">On 2023-06-19 21:49, Michael Geddes wrote:</p>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">
<div id="replybody1">
<div dir="auto">Oh, I just realised I did not clarify that the example VIN code is where I'm heading to.. Not what exists now. Presumably you looked at what I have now in the Ioniq 5 code.
<div dir="auto"> </div>
<div dir="auto">There are keep-alive mechanisms and examples around. </div>
<div dir="auto"> </div>
<div dir="auto"> </div>
<div dir="auto">Michael</div>
</div>
<br />
<div class="v1gmail_quote">
<div class="v1gmail_attr" dir="ltr">On Sat, 17 June 2023, 7:46 pm Solterra, <<a href="mailto:solterra@kezarnet.com" rel="noreferrer">solterra@kezarnet.com</a>> wrote:</div>
<blockquote class="v1gmail_quote" style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;">
<div style="font-size: 10pt; font-family: Verdana,Geneva,sans-serif;">
<p>Thanks for the tips.</p>
<p>For my first question, I initially copied the what the Ionic5 module did for VIN request, but it doesn't really fit with the framework of my vehicle module. I'm in the process of refactoring and figured there were other instances where I'll just want to send a one-time poll and let the framework process the response. Your response points me down the right path...</p>
<p>For my second question, I'm considering a command where I need to enter a UDS diagnostic session and will need to add a poll to keep the ECU in that session. I don't always need the poll, but once I do I need it every 2 seconds or so. Then, at the end of the session, I'll return the polling back to the 'standard'.</p>
<div id="v1m_-2026151157016874020signature"></div>
<p>Things are going well with my module, by the way. I'm having trouble where the communications gateway ECU goes to sleep when the vehicle is 'off' and I dont yet know how to wake it up. This might cause some charging sessions to be missed. I haven't decided if I care yet or not, as my initial use case is most important when the vehicle is on.</p>
<p>I'm going to do some reverse engineering of the Toyota TIS software communication today to see how they keep the communications gateway ECU awake.</p>
<p><br /></p>
<p id="v1m_-2026151157016874020reply-intro">On 2023-06-17 03:01, Michael Balzer wrote:</p>
<blockquote style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0;">
<div id="v1m_-2026151157016874020replybody1">
<div>Solterra,<br /><br />
<div>Am 17.06.23 um 01:37 schrieb Solterra:</div>
<blockquote style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0;">Is there a recommended method for adding a one-time CAN poll to the queue with the response to be processed by IncomingPollReply?</blockquote>
<br />For single-shot requests you can either use the synchronous `OvmsVehicle::PollSingleRequest()` method(s) or temporarily replace the PID list via `OvmsVehicle::PollSetPidList()`.<br /><br />For the latter, you'd reinstall your standard PID list in the incoming handler once you've received the response.<br /><br />
<blockquote style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0;">What is the recommended method for adding or modifying obdii_polls after initialization?</blockquote>
<br />In most situations you only need to switch polls partially or change the poll frequency. For this, use the up to four poll state timings per list entry, and call `OvmsVehicle::PollSetState()` to switch the current state.<br /><br />If you need to fully replace a poll list:<br />
<ol>
<li>Lock the poller mutex</li>
<li>Remove the current PID list</li>
<li>Create / modify your PID list</li>
<li>Install the new / modified PID list</li>
<li>Unlock the poller mutex</li>
</ol>
For dynamically created PID lists and/or combining predefined with dynamic entries, use a C++ std::vector & std::initializer_list.<br /><br />For a full example of this and also an example for how to do the PID list update, see the `vehicle_vweup` OBD module:<br />
<ul>
<li><a href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle_vweup/src/vehicle_vweup.h#L83" target="_blank" rel="noopener noreferrer">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle_vweup/src/vehicle_vweup.h#L83</a></li>
<li><a href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle_vweup/src/vweup_obd.cpp#L217" target="_blank" rel="noopener noreferrer">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/master/vehicle/OVMS.V3/components/vehicle_vweup/src/vweup_obd.cpp#L217</a></li>
</ul>
Regards,<br />Michael<br /><br />
<pre>--
Michael Balzer * Helkenberger Weg 9 * D-58256 Ennepetal
Fon 02333 / 833 5735 * Handy 0176 / 206 989 26</pre>
</div>
</div>
<br />
<div style="margin: 0; padding: 0; font-family: monospace;">_______________________________________________<br />OvmsDev mailing list<br /><a href="mailto:OvmsDev@lists.openvehicles.com" rel="noreferrer">OvmsDev@lists.openvehicles.com</a><br /><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank" rel="noopener noreferrer">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></div>
</blockquote>
</div>
_______________________________________________<br />OvmsDev mailing list<br /><a href="mailto:OvmsDev@lists.openvehicles.com" rel="noreferrer">OvmsDev@lists.openvehicles.com</a><br /><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank" rel="noopener noreferrer">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></blockquote>
</div>
</div>
<br />
<div class="pre" style="margin: 0; padding: 0; font-family: monospace">_______________________________________________<br />OvmsDev mailing list<br /><a href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a><br /><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" target="_blank" rel="noopener noreferrer">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></div>
</blockquote>
</body></html>