<html><head>
</head>
<body><div>After wolfssh was deleted during the fetch I did</div><div><br></div><div>git submodule update --init --recursive</div><div>git pull --recurse-submodules</div><div>git submodule update --remote</div><div><br></div><div>Then I was stranded with the wrong wolfssh version.</div><div><br></div><div>git submodule sync --recursive</div><div><br></div><div>corrected the wolfssh version now.</div><div><br></div><div>Sorry for my words on "experimenting". Sometimes the complexity of it all is a bit frustrating.</div><div><br></div><div><br></div><div>Am Samstag, dem 13.05.2023 um 21:37 +0200 schrieb Ludovic LANGE:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div class="moz-cite-prefix">Chris,</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Very puzzling what you experience. As I did exactly the same in a fresh dir without any issue:<br></div><div class="moz-cite-prefix"> <ul> <li><font face="monospace">git clone <a class="moz-txt-link-abbreviated" href="mailto:git@github.com:openvehicles/Open-Vehicle-Monitoring-System-3.git">git@github.com:openvehicles/Open-Vehicle-Monitoring-System-3.git</a></font></li> <li><font face="monospace">cd Open-Vehicle-Monitoring-System-3/</font><font face="monospace"></font></li> <li><font face="monospace">git submodule update --init --recursive<br></font></li> <li><font face="monospace">cd vehicle/OVMS.V3/</font></li> <li><font face="monospace">cp support/sdkconfig.default.hw31 sdkconfig</font></li> <li><font face="monospace">make<br></font></li></ul></div><div class="moz-cite-prefix">(And compilation was OK)<br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">In particular you can see the reverts here :<a class="moz-txt-link-freetext" href="https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commits/master">https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/commits/master</a></div><div class="moz-cite-prefix"> <ul> <li>7b1c932eab4e00d6a20ba1cc8f30d7dbf6db7e2d : Revert "compatibility with WolfSSH >= 1.4.12"<br></li> <li>beaada5aaa6c76da2d83612d263a1f3eb17e240c : Revert "Upgrade wolfssh 1.4.13"<br></li></ul><p>Can you confirm that in your local dir you have these 2 commits ? And that the last commit id is indeed e7f41bd8d9aabc0cecba369dc1b7e3641e748d17 ?</p><p><br></p><p>Are other people on the list experience the same as Chris does here ? I know that Github has had some issues in the past week but I'm very puzzled about the different experiences between both of us.</p><p><br></p><p>Regarding your last comment on master : I do take full responsibility for the issue you're facing, as I did wrongly communicate about the order of PRs that should have been applied to master. However, it was not an experimentation - the experimentation has been properly done on a branch as expected.<br></p></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Regards,<br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Le 13/05/2023 à 21:14, Chris van der Meijden a écrit :<br></div><div> <meta http-equiv="content-type" content="text/html; charset=UTF-8"></div><div>OK ... I deleted the master from my repo on github ... Did a fresh pull from OVMS master to my local and then a fresh push from there to a new master in my github repo.</div><div><br></div><div>Compiling does not work, so this will also be the case for anyone pulling fresh from master.</div><div><br></div><div>That is not good ... The OVMS master needs urgently to be restored to a working repository.</div><div><br></div><div>I would also like to suggest to stop experimenting with OVMS master and use a branch instead untill things are stable.</div><div><br></div><div><br></div><div><br></div><div>Am Samstag, dem 13.05.2023 um 19:59 +0200 schrieb Chris van der Meijden:</div><div> <br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Could you please explain in detail what I need to do?</div><div><br></div><div>I tried to pull the code completely fresh from master. That does not work.</div><div><br></div><div>What if a new user tries to compile from scratch? Will they run into the same issues?</div><div><br></div><div><br></div><div><br></div><div>Am Samstag, dem 13.05.2023 um 19:32 +0200 schrieb Ludovic LANGE:</div><div class="moz-cite-prefix">Hi Chris,</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Yes we unfortunately had an issue where we merged, then reverted a patch.</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">It seems that unfortunately it didn't work for you. Could you try to fetch, then reset your git repo to HEAD, it seems you did not fetch the "revert" patches ?</div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Let us know.<br></div><div class="moz-cite-prefix"><br></div><div class="moz-cite-prefix">Le 13/05/2023 à 19:08, Chris van der Meijden a écrit :<br></div><div> <meta http-equiv="content-type" content="text/html;
charset=UTF-8"></div><div>Today I pulled the newest version. During the pull my Wolfssh directory was deleted. I then renewed all the submodules and I got the newest Wolfssh.</div><div><br></div><div>But now the verion 3.3.003-467-ge7f41bd8-dirty won't compile (why is it "dirty" anyways, I didn't change the code ...).</div><div><br></div><div>First I get</div><div><br></div><div>CXX build/console_ssh/src/console_ssh.o</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/console_ssh/src/console_ssh.cpp: In function 'void wolfssh_logger(wolfSSH_LogLevel, const char*)':</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/console_ssh/src/console_ssh.cpp:1176:10: error: enumeration value 'WS_LOG_CERTMAN' not handled in switch [-Werror=switch]</div><div> switch (level)</div><div> ^</div><div><br></div><div>Then I add case WS_LOG_CERTMAN: on line 1178:</div><div><br></div><div>static void wolfssh_logger(enum wolfSSH_LogLevel level, const char* const msg)</div><div> {</div><div> switch (level)</div><div> {</div><div> case WS_LOG_CERTMAN:</div><div>...</div><div><br></div><div>But the I run into this error:</div><div><br></div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c: In function 'IdentifyKey':</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:883:9: warning: unused variable 'dynType' [-Wunused-variable]</div><div> int dynType = isPrivate ? DYNTYPE_PRIVKEY : DYNTYPE_PUBKEY;</div><div> ^</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c: In function 'DoKexDhReply':</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:3947:17: error: implicit declaration of function 'PRIVATE_KEY_UNLOCK' [-Werror=implicit-function-declaration]</div><div> PRIVATE_KEY_UNLOCK();</div><div> ^</div><div>/home/chris/OVMS/Open-Vehicle-Monitoring-System-3/vehicle/OVMS.V3/components/wolfssh/wolfssh/src/internal.c:3952:17: error: implicit declaration of function 'PRIVATE_KEY_LOCK' [-Werror=implicit-function-declaration]</div><div> PRIVATE_KEY_LOCK();</div><div> ^</div><div><br></div><div>Any ideas?</div><div><br></div><div>Regards Chris</div><div><br></div><div><span></span></div><div> <br> <fieldset class="moz-mime-attachment-header"></fieldset></div><pre>_______________________________________________</pre><pre>OvmsDev mailing list</pre><pre><a class="moz-txt-link-abbreviated moz-txt-link-freetext" href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true">OvmsDev@lists.openvehicles.com</a></pre><pre><a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></pre><p><br></p><div>_______________________________________________<br></div><div>OvmsDev mailing list<br></div><div><a href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true" class="moz-txt-link-freetext">OvmsDev@lists.openvehicles.com</a><br></div><div><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true" class="moz-txt-link-freetext">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br></div><div><br></div><div><span></span></div><div>_______________________________________________<br></div><div>OvmsDev mailing list<br></div><div><a href="mailto:OvmsDev@lists.openvehicles.com" moz-do-not-send="true" class="moz-txt-link-freetext">OvmsDev@lists.openvehicles.com</a><br></div><div><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev" moz-do-not-send="true" class="moz-txt-link-freetext">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br></div></blockquote><div><br></div><div><span></span></div><div> <br> <fieldset class="moz-mime-attachment-header"></fieldset></div><pre>_______________________________________________</pre><pre>OvmsDev mailing list</pre><pre><a class="moz-txt-link-abbreviated" href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a></pre><pre><a class="moz-txt-link-freetext" href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a></pre><p><br></p><div id="grammalecte_menu_main_button_shadow_host" style="width:
0px; height: 0px;"></div><div>_______________________________________________<br></div><div>OvmsDev mailing list<br></div><div><a href="mailto:OvmsDev@lists.openvehicles.com">OvmsDev@lists.openvehicles.com</a><br></div><div><a href="http://lists.openvehicles.com/mailman/listinfo/ovmsdev">http://lists.openvehicles.com/mailman/listinfo/ovmsdev</a><br></div></blockquote><div><br></div><div><span></span></div></body></html>